Ticket #28640: portlint2.diff

portlint.tcl

@@ -154 +154 @@
     array set portgroups {}
 
     set local_variants [list]
+    set local_dependstypes [list]
 
     set f [open $portfile RDONLY]
     # read binary (to check UTF-8)
@@ -331 +332 @@
 
         ### TODO: more checks to Portfile syntax
 
+        # If portfile uses PortGroup, check current portfile for any depends_* without
+        # -append.  If so, save them for later.
+        if ($seen_portgroup) {
+            if {[regexp {^(?:\s*)depends_([a-z]+)(.)(?:.*)} $line -> dependtype haveappend]} {
+                if {$haveappend ne "-"} {
+                    lappend local_dependstypes $dependtype
+                }
+            }
+        }
+
         incr lineno
     }
 
@@ -357 +368 @@
     if ($seen_portgroup) {
         # Using a PortGroup is optional
         foreach {portgroup portgroupversion} [array get portgroups] {
-            if {![file exists [getportresourcepath $porturl "port1.0/group/${portgroup}-${portgroupversion}.tcl"]]} {
+            set portfile [getportresourcepath $porturl "port1.0/group/${portgroup}-${portgroupversion}.tcl"]
+            if {![file exists $portfile]} {
                 ui_error "Unknown PortGroup: $portgroup-$portgroupversion"
                 incr errors
             } else {
                 ui_info "OK: Found PortGroup $portgroup-$portgroupversion"
+
+                # Determine if PortGroup has any depends_* matching local Portfile's
+                set f [open $portfile RDONLY]
+                while {1} {
+                    set line [gets $f]
+                    # Does depends_*-append in PortGroups make a difference to whether a port should use -append?
+                    if {[regexp {^(?:\s*)depends_([a-z]+)(.)(?:.*)} $line -> dependtype haveappend]} {
+                        if {[lsearch -exact $local_dependstypes $dependtype] >= 0} {
+                            ui_error "PortGroup $portgroup uses depends_$dependtype, so use depends_$dependtype-append"
+                            # Remove this dependtype to avoid duplicate messages
+                            set local_dependstypes [lsearch -all -inline -not -exact $local_dependstypes $dependtype]
+                            incr errors
+                        }
+                    }
+                    if {[eof $f]} {
+                        close $f
+                        break
+                    }
+                }
             }
         }
     }