Ticket #38626: oracle-instantclient.2.diff

Portfile

@@ -19 +19 @@
 if {"powerpc" == ${os.arch}} {
     epoch               1
     version             10.1.0.3
+    revision            1
     set library_version 10.1
     supported_archs     ppc
     universal_variant   no
@@ -40 +41 @@
     livecheck.type      none
 } else {
     version             11.2.0.3.0
+    revision            1
     set library_version 11.1
     supported_archs     x86_64 i386
     variant universal {}
@@ -135 +137 @@
 set lib_dir             ${prefix}/lib/oracle
 
 build {
-    # Oracle builds the libraries with strange install_names, which we fix, for
-    # neatness. Unfortunately users must still set DYLD_LIBRARY_PATH in their
-    # environment because one of the libraries, libociei, is dynamically loaded
-    # at runtime rather than being linked to.
     foreach my_arch ${configure.universal_archs} {
+        # Oracle builds the libraries with strange install_names; fix them.
         # For each dylib, change the directory of its install_name to ${lib_dir}.
         foreach lib [glob -directory ${workpath}/build/${my_arch} *.dylib*] {
             system "install_name_tool -id ${lib_dir}/[strsed ${lib} /^.*\\///] ${lib}"
@@ -151 +150 @@
                     system "install_name_tool -change ${dep} ${lib_dir}/[strsed ${dep} /^.*\\///] ${lib}"
                 }
             }
+            
+            # libociei is special: it's not linked to; it's dynamically loaded at
+            # runtime by libclntsh. Oracle says you have to set DYLD_LIBRARY_PATH
+            # to include ${lib_dir}, but adding an rpath works too.
+            if {[string match "*/libclntsh.dylib*" ${lib}]} {
+                system "install_name_tool -add_rpath ${lib_dir} ${lib}"
+            }
         }
     }
 }
@@ -182 +188 @@
 }
 
 notes "
-To use ${name}, add this command to your environment:
-
-export DYLD_LIBRARY_PATH=${lib_dir}
+If you previously set DYLD_LIBRARY_PATH=${lib_dir} in your environment, you can remove\
+it\; it is no longer needed with this version of ${name}.
 "