Ticket #48692: portlint.diff

port1.0/portlint.tcl

@@ -149 +149 @@
     set require_after ""
     set seen_portsystem false
     set seen_portgroup false
+    set seen_revision false
     set in_description false
 
     array set portgroups {}
@@ -329 +330 @@
             incr errors
         }
 
+        if {[string match "revision*" $line]} {
+            set seen_revision true
+        }
+
         ### TODO: more checks to Portfile syntax
 
         incr lineno
@@ -430 +435 @@
         ui_error "Port revision is not numeric: $revision"
         incr errors
     }
+    if {$seen_revision && [string is integer -strict $revision] && $revision == 0} {
+        ui_warn "Port revision matches the default so no need to include it: $revision"
+        incr warnings
+    }
 
     set variantnumber 1
     foreach variant $all_variants {