Ticket #6371: osx.diff

pkg/win32/Makefile.am

@@ -10 +10 @@
 EXTRA_DIST = \
     $(srcdir)/Make.bat \
     $(srcdir)/README.txt \
+    $(srcdir)/upgrade.bat \
     $(srcdir)/resources/banner.bmp \
     $(srcdir)/resources/new.bmp \
     $(srcdir)/resources/up.bmp \

pkg/win32/upgrade.bat

@@ +1 @@
+@echo off
+cls
+echo This file will upgrade your pgAdmin III installation.
+echo.
+echo You must have pgAdmin III v1.4.x installed 
+echo from the official MSI installation to use this upgrade path.
+echo.
+echo If pgAdmin III or any of it's components are in use
+echo a reboot will be required once the upgrade is completed.
+echo.
+echo.
+echo Press Ctrl-C to abort the upgrade or
+pause
+
+REM Parameters described:
+REM  /i pgadmin3.msi           - pick MSI file to install. All properties
+REM                              will be read from existing installation.
+REM  REINSTALLMODE=vamus       - reinstall all files, regardless of version.
+REM                              This makes sure documentation and other
+REM                              non-versioned files are updated.
+REM  REINSTALL=ALL             - Reinstall all features that were previously
+REM                              installed with the new version.
+msiexec /i pgadmin3.msi REINSTALLMODE=vamus REINSTALL=ALL /qr

src/include/ctl/ctlComboBox.h

@@ -25 +25 @@
 public:
     ctlComboBoxFix(wxWindow *wnd, int id, wxPoint pos, wxSize siz, long attr);
 
-#if wxCHECK_VERSION(2,6,2)
+#if wxCHECK_VERSION(2,6,2) && !defined(__WXMAC__)
     // we have GetCurrentSelection() in wxChoice, implementing the old GetSelection() semantics
 #else
     int GetCurrentSelection() const { return wxComboBox::GetSelection(); }
@@ -52 +52 @@
 #ifdef __WXMSW__
     wxString GetValue() const { return wxGetWindowText(GetHwnd()); }
 #endif
-
-
-private:
-    // to prevent using it; use GetCurrentSelection() instead
-    int GetSelection() const { return -1; }
 };
 
 class ctlComboBox : public ctlComboBoxFix

src/schema/pgLanguage.cpp

@@ -47 +47 @@
         if (GetTrusted())
             sql += wxT("TRUSTED ");
         sql += wxT("PROCEDURAL LANGUAGE '") + GetName() 
-            +  wxT("'\n  HANDLER ") + GetHandlerProc() + wxT(";\n")
+            +  wxT("'\n  HANDLER ") + GetHandlerProc();
+
+        if (!GetValidatorProc().IsEmpty())
+            sql += wxT("\n  VALIDATOR ") + GetValidatorProc();
+        
+        sql += wxT(";\n")
             +  GetGrant(wxT("X"), wxT("LANGUAGE ") + GetQuotedFullIdentifier());
 
     }

src/schema/pgSchema.cpp

@@ -163 +163 @@
 
     pgSet *schemas = collection->GetDatabase()->ExecuteSet(
         wxT("SELECT CASE WHEN nspname LIKE 'pg\\_temp\\_%%' THEN 1\n")
-        wxT("            WHEN (nsp.oid<") + NumToStr(collection->GetServer()->GetLastSystemOID()) +
-                         wxT(" OR nspname like 'pg\\_%') AND nspname != 'public' THEN 0\n")
+        wxT("            WHEN (nspname LIKE 'pg\\_%' OR nspname = 'information_schema') THEN 0\n")
         wxT("            ELSE 3 END AS nsptyp,\n")
         wxT("       nsp.nspname, nsp.oid, pg_get_userbyid(nspowner) AS namespaceowner, nspacl, description,")
         wxT("       has_schema_privilege(nsp.oid, 'CREATE') as cancreate\n")

src/schema/pgObject.cpp

@@ -162 +162 @@
 bool pgObject::UpdateIcon(ctlTree *browser)
 {
     int icon=GetIconId();
-    if (browser->GetItemImage(GetId(), wxTreeItemIcon_Normal) != icon)
+    if (GetId() && browser->GetItemImage(GetId(), wxTreeItemIcon_Normal) != icon)
     {
         browser->SetItemImage(GetId(), GetIconId(), wxTreeItemIcon_Normal);
         browser->SetItemImage(GetId(), GetIconId(), wxTreeItemIcon_Selected);

src/slony/include/slSubscription.h

@@ -59 +59 @@
 
   
     bool CanCreate();
+    bool CanDrop();
 
     bool DropObject(wxFrame *frame, ctlTree *browser, bool cascaded);
     wxString GetSql(ctlTree *browser);

src/slony/slSubscription.cpp

@@ -61 +61 @@
 }
 
 
+bool slSubscription::CanDrop()
+{
+    return GetReceiverId() == GetCluster()->GetLocalNodeID();
+}
+
+
 wxString slSubscription::GetSql(ctlTree *browser)
 {
     if (sql.IsNull())

src/slony/slNode.cpp

@@ -171 +171 @@
                 wxT("       st_last_event_ts - st_last_received_ts AS eventlag,")
                 wxT("       ev_seqno, ev_type || ' ' || COALESCE(ev_data1, '') AS hanging\n")
                 wxT("  FROM ") + GetCluster()->GetSchemaPrefix() + wxT("sl_status\n")
-                wxT("  LEFT JOIN ") + GetCluster()->GetSchemaPrefix() + wxT("sl_event ON ev_seqno=\n")
+                wxT("  LEFT JOIN ") + GetCluster()->GetSchemaPrefix() + wxT("sl_event ON ev_origin=st_origin AND ev_seqno=\n")
                 wxT("         (SELECT MIN(ev_seqno) FROM ") + GetCluster()->GetSchemaPrefix() + wxT("sl_event WHERE ev_seqno > st_last_received)\n")
                 wxT(" WHERE st_origin = ") + NumToStr(GetCluster()->GetLocalNodeID()) + wxT("\n")
                 wxT("   AND st_received = ") + NumToStr(GetSlId()));
@@ -331 +331 @@
         wxT("       CASE WHEN st_lag_num_events > 0 THEN st_last_event_ts - st_last_received_ts END AS eventlag,")
         wxT("       ev_seqno, ev_type || ' ' || COALESCE(ev_data1, '') AS hanging\n")
         wxT("  FROM ") + GetCluster()->GetSchemaPrefix() + wxT("sl_status\n")
-        wxT("  LEFT JOIN ") + GetCluster()->GetSchemaPrefix() + wxT("sl_event ON ev_seqno=\n")
+        wxT("  LEFT JOIN ") + GetCluster()->GetSchemaPrefix() + wxT("sl_event ON ev_origin=st_origin AND ev_seqno=\n")
         wxT("         (SELECT MIN(ev_seqno) FROM ") + GetCluster()->GetSchemaPrefix() + wxT("sl_event WHERE ev_seqno > st_last_received)\n")
         wxT(" WHERE st_origin = ") + NumToStr(GetCluster()->GetLocalNodeID()));