Gmail Ryan Stonecipher-Fisher <ryan.stonecipher.fisher@gmail.com>
[k3b] K3b 2.0 RC2
7 messages
Michał Małek <michalm@jabster.pl> Tue, Mar 9, 2010 at 1:25 AM
To: K3B <k3b@kde.org>
Hi,
I want to release 2.0 RC2. It contains translation files that were missed in
RC1. Tarball is here:
https://sourceforge.net/projects/k3b/files/k3b/1.91.0rc2/k3b-1.91.0rc2.tar.bz2/download
Markus, could you check if I got it right this time and all *.po files are
there?

--
Best regards,
Michał
Markus <kamikazow@web.de> Tue, Mar 9, 2010 at 3:16 PM
To: k3b@kde.org
Am Dienstag 09 März 2010 08:25:58 schrieb Michał Małek:
[Quoted text hidden]
Everything looks fine. Yay! :-)
Ryan Stonecipher-Fisher <rmsfisher@macports.org> Wed, Mar 10, 2010 at 7:15 AM
To: k3b@kde.org
Hey y'all,
I'm working on porting k3b to OS X as part of the MacPorts project.
So far I have met all dependencies for 1.91.0 except musicbrainz and
musepack, so k3b configures fine and begins building.
I'm encountering an error when building:

/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:
In constructor 'K3b::Device::Device::Private::Private()':
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:123:
error: 'HANDLE_DEFAULT_VALUE' was not declared in this scope
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:
In member function 'bool K3b::Device::Device::open(bool) const':
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:1800:
error: 'HANDLE_DEFAULT_VALUE' was not declared in this scope
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:1803:
error: 'HANDLE_DEFAULT_VALUE' was not declared in this scope
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:
In member function 'void K3b::Device::Device::close() const':
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:1811:
error: 'HANDLE_DEFAULT_VALUE' was not declared in this scope
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:1821:
error: 'HANDLE_DEFAULT_VALUE' was not declared in this scope
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:
In member function 'bool K3b::Device::Device::isOpen() const':
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/libk3bdevice/k3bdevice.cpp:1827:
error: 'HANDLE_DEFAULT_VALUE' was not declared in this scope
Linking CXX executable k3bsetuphelper.app/Contents/MacOS/k3bsetuphelper
cd /opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/k3bsetup
&& /opt/local/bin/cmake -E cmake_link_script
CMakeFiles/k3bsetuphelper.dir/link.txt --verbose=1
/usr/bin/g++-4.2    -arch x86_64 -isysroot
/Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -O2 -arch
x86_64  -fno-common -Woverloaded-virtual -fvisibility=hidden
-fvisibility-inlines-hidden -O2 -DNDEBUG -DQT_NO_DEBUG
-Wl,-search_paths_first -headerpad_max_install_names -L/opt/local/lib
CMakeFiles/k3bsetuphelper.dir/k3bsetuphelper_automoc.o
CMakeFiles/k3bsetuphelper.dir/k3bsetupworker.o
CMakeFiles/k3bsetuphelper.dir/k3bsetupprogramitem.o  -o
k3bsetuphelper.app/Contents/MacOS/k3bsetuphelper
-F/opt/local/libexec/qt4-mac/lib -L/opt/local/lib
/opt/local/lib/libkdecore.5.4.0.dylib -framework QtDBus -framework
QtCore -lpthread -framework Carbon
make[2]: *** [libk3bdevice/CMakeFiles/k3bdevice.dir/k3bdevice.o] Error 1
make[1]: *** [libk3bdevice/CMakeFiles/k3bdevice.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
cd /opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/k3bsetup
&& /opt/local/bin/cmake
-D_filename=/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/k3bsetup/k3bsetuphelper.app/Contents/MacOS/k3bsetuphelper.shell
-D_library_path_variable=DYLD_LIBRARY_PATH
-D_ld_library_path="/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/lib/./:/opt/local/lib"
-D_executable=/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/k3bsetup/k3bsetuphelper.app/Contents/MacOS/k3bsetuphelper
-P /opt/local/share/apps/cmake/modules/kde4_exec_via_sh.cmake
/opt/local/bin/cmake -E cmake_progress_report
/opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work/k3b-1.91.0/CMakeFiles
 59
[ 38%] Built target k3bsetuphelper
make: *** [all] Error 2

I'm just doing this MacPorts stuff as a hobby and am a mechanical
engineer, not a programmer, so any advice on how to find and fix the
source of this error would be appreciated.

Cheers,

Ryan Stonecipher-Fisher
573.489.2848
[Quoted text hidden]
Markus <kamikazow@web.de> Wed, Mar 10, 2010 at 7:37 AM
To: k3b@kde.org
Am Mittwoch 10 März 2010 14:15:13 schrieb Ryan Stonecipher-Fisher:
> Hey y'all,
> I'm working on porting k3b to OS X as part of the MacPorts project.
> So far I have met all dependencies for 1.91.0 except musicbrainz and
> musepack, so k3b configures fine and begins building.

IMHO this shouldn't be a blocker to not release RC2, but it should be fixed
before the final release.
Michał Małek <michalm@jabster.pl> Wed, Mar 10, 2010 at 1:35 PM
To: k3b@kde.org
[Quoted text hidden]
> tuphelper -P /opt/local/share/apps/cmake/modules/kde4_exec_via_sh.cmake
> /opt/local/bin/cmake -E cmake_progress_report
> /opt/local/var/macports/build/_Volumes_Users_ryan_Builds_ports_kde_k3b/work
> /k3b-1.91.0/CMakeFiles 59
> [ 38%] Built target k3bsetuphelper
> make: *** [all] Error 2
>
> I'm just doing this MacPorts stuff as a hobby and am a mechanical
> engineer, not a programmer, so any advice on how to find and fix the
> source of this error would be appreciated.

Hi,
Well, you stumbled upon the first thing to port :)
At the beginning of k3bdevice.cpp file you can find following fragment:

#ifdef Q_OS_FREEBSD
#define HANDLE_DEFAULT_VALUE 0
#endif
#ifdef Q_OS_WIN32
#define HANDLE_DEFAULT_VALUE INVALID_HANDLE_VALUE
#endif
#ifdef Q_OS_LINUX
#define HANDLE_DEFAULT_VALUE -1
#endif
#ifdef Q_OS_NETBSD
#define HANDLE_DEFAULT_VALUE -1
#endif

Because there is no #ifdef Q_OS_MAC condition here, HANDLE_DEFAULT_VALUE
doesn't become defined and compiler complains about it when it's used later.
Look also into k3bdevice.h for definition of Device::Handle:

#if defined(Q_OS_FREEBSD)
           typedef struct cam_device* Handle;
#elif defined(Q_OS_WIN32)
           // file handle
           typedef HANDLE Handle;
#else
           // file descriptor
           typedef int Handle;
#endif

Find how the file descriptor looks like on Mac OS X and than define it's
default value (HANDLE_DEFAULT_VALUE) accordingly. E.g. if it's "int" add

#ifdef Q_OS_MAC
#define HANDLE_DEFAULT_VALUE -1
#endif

--
Best regards,
Michał
Michał Małek <michalm@jabster.pl> Wed, Mar 10, 2010 at 1:41 PM
To: k3b@kde.org
[Quoted text hidden]
Porting to Mac has just been started. There are a lot of things non-trivial to
port (e.g. SCSI commands handling) so this can take a while to make it work. I
don't think we should wait with final release for that.

--
Best regards,
Michał
Markus <kamikazow@web.de> Wed, Mar 10, 2010 at 2:59 PM
To: k3b@kde.org
> Porting to Mac has just been started. There are a lot of things non-trivial
> to port (e.g. SCSI commands handling) so this can take a while to make it
> work. I don't think we should wait with final release for that.

Yeah, sounds reasonable