| 1 | | I tested the latest version on a few ports, and they all worked. I don't like the multiple use of "mkdir" even when it is unnecessary (not out of tree build), but it works (I think 'port' internally either checks to see if the directory already exists & if so then does nothing, or just ignores what the system call returns; I didn't test beyond this). That said, I would prefer to not break anything up front, so allow ports to opt in as they can. Somewhere down the road we do a swap-around & fix whatever is left. This could be done via a cmake-1.1 PortGroup, yes; that might be the better way to do this, since it would require no changes down the road. |
| | 1 | I tested the latest version on a few ports, and they all worked. I don't like the multiple use of "mkdir" even when it is unnecessary (not out of tree build), but it works (I think 'port' internally either checks to see if the directory already exists & if so then does nothing, or just ignores what the system call returns; I didn't test beyond this). That said, I would prefer to not break anything up front, so allow ports to opt in as they can. Somewhere down the road we do a swap-around & fix whatever is left. This could be done via a cmake-1.1 PortGroup, yes; that might be the better way to do this, since it would require no changes down the road. I vote for going ahead and committing. I'll probably tweak the mkdir stuff to make me happy :) |
