Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#37700 closed update (fixed)

Update gtk-osx-application to 2.0.1

Reported by: macports@… Owned by: elelay (Eric Le Lay)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc: su-v
Port: gtk-osx-application

Description (last modified by ryandesign (Ryan Carsten Schmidt))

The current gtk-osx-application in MacPorts is v1.0.1, while the latest is 2.0.1. I have included a patch that updates this package to the latest.

Apply with:

cd /opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel
patch -p0 <gtk-osx-application-2.0.1.patch

Attachments (1)

gtk-osx-application-2.0.1.patch (7.7 KB) - added by macports@… 12 years ago.
Updated patch, with whitespace fixes, revision set to 0 and gtkosxapplication.h patch removed

Download all attachments as: .zip

Change History (11)

comment:2 Changed 12 years ago by su-v

Cc: suv-sf@… added

Cc Me!

comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Keywords: haspatch added
Owner: changed from macports-tickets@… to elelay@…

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

The revision should drop to 0.

comment:5 Changed 12 years ago by su-v

AFAICT (please verify) the patch file 'patch-gtkosxapplication.h.diff' is no longer required (fixed upstream):
http://git.gnome.org/browse/gtk-mac-integration/commit/?id=e673d9b59fce3f947e64a399b57eca67297f725c

comment:6 Changed 12 years ago by macports@…

I get an error if I don't apply my patch:

:info:build cocoa_menu_item.c:527:60: error: incompatible operand types ('const gchar *' (aka 'const char *') and 'NSString *')
:info:build     NSString *title = [NSString stringWithUTF8String:(text ? text : @"")];
:info:build                                                            ^ ~~~~   ~~~

I don't really know why, though.

Version 1, edited 12 years ago by macports@… (previous) (next) (diff)

Changed 12 years ago by macports@…

Updated patch, with whitespace fixes, revision set to 0 and gtkosxapplication.h patch removed

comment:7 Changed 12 years ago by macports@…

You were right, the gtkosxapplication.h patch wasn't needed. I've updated the patch, with additional whitespace fixes.

comment:8 in reply to:  7 Changed 12 years ago by elelay (Eric Le Lay)

Replying to macports@…:

You were right, the gtkosxapplication.h patch wasn't needed. I've updated the patch, with additional whitespace fixes.

got it, Thanks ! I'm in the process of building and testing it and will release by the end of the week.

comment:9 Changed 12 years ago by elelay (Eric Le Lay)

applied in r102041 Thanks for the quality patch :-)

comment:10 Changed 12 years ago by elelay (Eric Le Lay)

Resolution: fixed
Status: newclosed

comment:12 Changed 12 years ago by su-v

WRT to John Rall's reply in Re: patches to GTKOSXApplication: to avoid the build failure in 'cocoa_menu_item.c' with clang, consider using llvm-gcc-4.2 as compiler (at least this works for me with Xcode 4.3.2 on Lion, and allows to install the port without the patch to 'cocoa_menu_item.c').

If I read the configuration file correctly (jhbuild setup), gtk-osx sets llvm-gcc-4.2 as default compiler on OS X >= 10.7, i.e. also when installing the module 'gtk-mac-integration'.

( Note: I'm not a developer myself and don't know why it fails with clang, nor do I have current external projects which would allow me to check whether the patched version has any side-effects for applications compiled with global menubar integration. )

Note: See TracTickets for help on using tickets.