RFE: Move "rec_glob" proc from nodejs portfile into base

[cooljeanius (Eric Gallager)]

I was looking through the nodejs portfile and came across this recursive glob function:

proc rec_glob {basedir pattern} {
    set files [glob -directory $basedir -nocomplain -type f $pattern]
    foreach dir [glob -directory $basedir -nocomplain -type d *] {
        eval lappend files [rec_glob $dir $pattern]
    }
    return $files
}

It would be useful to have this proc available in base so I wouldn't have to copy it from the nodejs portfile if I ever want to use it myself.

[ryandesign (Ryan Carsten Schmidt)]

Isn't this kind of thing what fs-traverse is for?

[cooljeanius (Eric Gallager)]

Replying to ryandesign@…:

Isn't this kind of thing what fs-traverse is for?

I wouldn't know, fs-traverse isn't documented in the guide and I don't know where it's located in the code, so I can't tell if they work the same way. '

[larryv (Lawrence Velázquez)]

Replying to egall@…:

It would be useful to have this proc available in base so I wouldn't have to copy it from the nodejs portfile if I ever want to use it myself.

I wasn’t aware that MacPorts base was your personal code snippet repository.

[larryv (Lawrence Velázquez)]

Replying to egall@…:

I wouldn't know, fs-traverse isn't documented in the guide and I don't know where it's located in the code, so I can't tell if they work the same way.

$ man portfile

[cooljeanius (Eric Gallager)]

Replying to larryv@…:

Replying to egall@…:

It would be useful to have this proc available in base so I wouldn't have to copy it from the nodejs portfile if I ever want to use it myself.

I wasn’t aware that MacPorts base was your personal code snippet repository.

Well I didn't mean just me personally; I thought it could be useful as a library function generally. I'm just speaking as an example here.

[larryv (Lawrence Velázquez)]

Replying to egall@…:

Well I didn't mean just me personally; I thought it could be useful as a library function generally.

fs-traverse is a more general function than this rec_glob; it executes a body of code for every file or directory in the given directory hierarchy. Of course, a port maintainer is free to define and use any procs they wish.

[cooljeanius (Eric Gallager)]

So apparently fs-traverse is a pextlib function... in that case the issue for documenting it in the guide is #15623.

[cooljeanius (Eric Gallager)]

Replying to larryv@…:

Replying to egall@…:

I wouldn't know, fs-traverse isn't documented in the guide and I don't know where it's located in the code, so I can't tell if they work the same way.

$ man portfile

Thanks, I will just use that in the meantime. However, in the longer term, it would make more sense for there to be a specific manpage for the proc itself that shared a name with it, so I could just do

$ man n fs-traverse

instead of having to remember that it was in the Portfile manpage, and then having to scroll down forever until I reach it.

[larryv (Lawrence Velázquez)]

Replying to egall@…:

Thanks, I will just use that in the meantime. However, in the longer term, it would make more sense for there to be a specific manpage for the proc itself that shared a name with it, so I could just do

$ man n fs-traverse

instead of having to remember that it was in the Portfile manpage, and then having to scroll down forever until I reach it.

The presence of such a manpage would imply that fs-traverse was a general Tcl proc intended for use outside of MacPorts, which it isn’t.