Changes between Version 12 and Version 13 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 6, 2013, 10:20:21 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v12 v13  
    1111|| `AC_CHECK_FUNCS([regcomp])` || `src/pextlib1.0/strsed.c:584` || `if (regcomp(&exp, from, 0) != 0){` || `ifdef`ed for use when `HS_REGEX` is defined. || Helps the `strsed` Pextlib function do regexes. It is already `ifdef`ed so the `ifdef` could simply be changed to `if defined(HS_REGEX) && defined(HAVE_REGCOMP)` instead. ||
    1212|| `AC_CHECK_FUNCS([rmdir])` || `src/darwintracelib1.0/darwintrace.c:1183` || `int rmdir(const char *path) {` || new function declaration || `/* Trap attempts to remove directories outside the sandbox. */` Make sure there are calls to `rmdir` to trap in the first place ||
    13 || `AC_CHECK_FUNCS([setenv])` || `src/pextlib1.0/Pextlib.c:409` ||
    14 || `AC_CHECK_FUNCS([socket])` || `src/darwintracelib1.0/darwintrace.c:589` ||
     13|| `AC_CHECK_FUNCS([setenv])` || `src/pextlib1.0/Pextlib.c:409` || `setenv("MACPORTS_DUMMY", "", 0);` || Inside an `#ifndef __APPLE__` for Linux environments. || `/* Crashes on Linux without this. */` Seeing as this test is for Linux anyways, and Linux is easier to break than OS X is, and it is already inside an `#ifndef`, the condition could easily be modified to check for `HAVE_SETENV` as well. ||
     14|| `AC_CHECK_FUNCS([socket])` || `src/darwintracelib1.0/darwintrace.c:589` || `if (-1 == (sock = socket(PF_LOCAL, SOCK_STREAM, 0))) {` || inside the part where `darwintrace` sets itself up || I actually do not really get what is going on here, but it would probably just be good to check for the `socket` function anyways. ||
    1515|| `AC_CHECK_FUNCS([strchr])` || `src/machista1.0/machista_wrap.c:1381` ||
    1616|| `AC_CHECK_FUNCS([strdup])` || `src/cregistry/entry.c:384` ||