Changes between Version 16 and Version 17 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 6, 2013, 10:37:59 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v16 v17  
    1313|| `AC_CHECK_FUNCS([setenv])` || `src/pextlib1.0/Pextlib.c:409` || `setenv("MACPORTS_DUMMY", "", 0);` || Inside an `#ifndef __APPLE__` for Linux environments. || `/* Crashes on Linux without this. */` Seeing as this test is for Linux anyways, and Linux is easier to break than OS X is, and it is already inside an `#ifndef`, the condition could easily be modified to check for `HAVE_SETENV` as well. ||
    1414|| `AC_CHECK_FUNCS([socket])` || `src/darwintracelib1.0/darwintrace.c:589` || `if (-1 == (sock = socket(PF_LOCAL, SOCK_STREAM, 0))) {` || inside the part where `darwintrace` sets itself up || I actually do not really get what is going on here, but it would probably just be good to check for the `socket` function anyways. ||
    15 || `AC_CHECK_FUNCS([strchr])` || `src/machista1.0/machista_wrap.c:1381` || `char* where = strchr(cr,':');` || I actually have no clue what is going on here; there are very few comments in this area of the code... || Even though I do not really get what this is used for here, it would still probably be a good idea to check for this function anyways. ||
    16 || `AC_CHECK_FUNCS([strdup])` || `src/cregistry/entry.c:384` || `query = strdup("SELECT id FROM registry.ports");` || In a registry searching function || `/* build the query */` Checking this would help ensure that registry-checking works properly. ||
    17 || `AC_CHECK_FUNCS([strerror])` || `src/macports1.0/sysctl.c:72` || `Tcl_AppendObjToObj(tcl_result, Tcl_NewStringObj(strerror(errno), -1));` || Used for an error that can result from checking `sysctl` || Checking for this could improve `sysctl` checking. ||
    18 || `AC_CHECK_FUNCS([strrchr])` || `src/darwintracelib1.0/darwintrace.c:894` ||
    19 || `AC_CHECK_FUNCS([strstr])` || `src/machista1.0/machista_wrap.c:1383` ||
    20 || `AC_CHECK_FUNCS([strtol])` || `src/pextlib1.0/Pextlib.c:206` ||
     15|| `AC_CHECK_FUNCS([strchr])` || `src/machista1.0/machista_wrap.c:1381` || `char* where = strchr(cr,':');` || I actually have no clue what is going on here; there are very few comments in this area of the code... || Even though I do not really get what this is used for here, it would still probably be a good idea to check for `strchr` for this anyways. ||
     16|| `AC_CHECK_FUNCS([strdup])` || `src/cregistry/entry.c:384` || `query = strdup("SELECT id FROM registry.ports");` || In a registry searching function || `/* build the query */` Checking for `strdup` for this would help ensure that registry-checking works properly. ||
     17|| `AC_CHECK_FUNCS([strerror])` || `src/macports1.0/sysctl.c:72` || `Tcl_AppendObjToObj(tcl_result, Tcl_NewStringObj(strerror(errno), -1));` || Used for an error that can result from checking `sysctl` || Checking for `strerror` for this could improve `sysctl` checking. ||
     18|| `AC_CHECK_FUNCS([strrchr])` || `src/darwintracelib1.0/darwintrace.c:894` || `char *lastSep = strrchr(normalizedpath, '/');` || Helps check paths against the sandbox || `/* walk up one directory */` Checking for `strrchr` for this could help with sandboxing, which currently has some issues: #39850 for example ||
     19|| `AC_CHECK_FUNCS([strstr])` || `src/machista1.0/machista_wrap.c:1383` || `where = strstr(where, meth->name);` || idk || I don't get this file; just check the `strstr` function anyways... ||
     20|| `AC_CHECK_FUNCS([strtol])` || `src/pextlib1.0/Pextlib.c:206` || `pwent = getpwuid(strtol(user, 0, 0));` || in the `ExistsuserCmd` function || There is no commentary around this, but it would probably be a good idea to check for the `strtol` function anyways... ||
    2121|| `AC_CHECK_FUNCS([strtoul])` || `src/machista1.0/machista_wrap.c:1820` ||
    2222|| `AC_CHECK_FUNCS([utime])` || `src/pextlib1.0/curl.c:438` ||