Changes between Version 20 and Version 21 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 6, 2013, 10:55:57 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v20 v21  
    3030|| `AC_CHECK_HEADER_STDBOOL` || `src/machista1.0/libmachista.c:247` || `bool universal = false;` || In a mach-o parsing function || `/* Parse the Mach-O header */` I do not get why `autoscan` says this macro is needed for this line instead of line 33 which has the actual `#include <stdbool.h>` on it, but whatever... ||
    3131|| `AC_C_INLINE` || `src/darwintracelib1.0/darwintrace.c:117` || `static inline int __darwintrace_strbeginswith(const char *str, const char *prefix);` || looks like a function prototype? || not sure why this uses `inline` (it looks like regular C to me), but if we're going to be using `inline` stuff, it'd probably be a good idea to have `autoconf` check how the compiler handles it... (also throw in the `AC_C_PROTOTYPES` macro in there while you're at it) ||
    32 || `AC_C_RESTRICT` || `src/darwintracelib1.0/darwintrace.c:774` ||
     32|| `AC_C_RESTRICT` || `src/darwintracelib1.0/darwintrace.c:774` || `static void frecv(void *restrict buf, size_t size) {` || function declaration || `/* Helper function to recieve a number of bytes from the tracelib communication socket and deal with any errors that might occur. */` Using `restrict` can be good for performance, have `autoconf` check how the compiler handles it to make sure ||
    3333|| `AC_FUNC_CHOWN` || `src/pextlib1.0/xinstall.c:1077` ||
    3434|| `AC_FUNC_FORK` || `src/machista1.0/tests/libmachista-test.c:25` ||