Changes between Version 21 and Version 22 of Ticket #38582, comment 6
- Timestamp:
- Aug 6, 2013, 10:59:31 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #38582, comment 6
v21 v22 31 31 || `AC_C_INLINE` || `src/darwintracelib1.0/darwintrace.c:117` || `static inline int __darwintrace_strbeginswith(const char *str, const char *prefix);` || looks like a function prototype? || not sure why this uses `inline` (it looks like regular C to me), but if we're going to be using `inline` stuff, it'd probably be a good idea to have `autoconf` check how the compiler handles it... (also throw in the `AC_C_PROTOTYPES` macro in there while you're at it) || 32 32 || `AC_C_RESTRICT` || `src/darwintracelib1.0/darwintrace.c:774` || `static void frecv(void *restrict buf, size_t size) {` || function declaration || `/* Helper function to recieve a number of bytes from the tracelib communication socket and deal with any errors that might occur. */` Using `restrict` can be good for performance, have `autoconf` check how the compiler handles it to make sure || 33 || `AC_FUNC_CHOWN` || `src/pextlib1.0/xinstall.c:1077` || 33 || `AC_FUNC_CHOWN` || `src/pextlib1.0/xinstall.c:1077` || `if ((gid != (gid_t)-1 || uid != (uid_t)-1) && chown(path, uid, gid))` || in a condition || Helps build the directory "`heirarchy` [sic]". Plus checking how `chown`ing works is probably a good idea anyways. || 34 34 || `AC_FUNC_FORK` || `src/machista1.0/tests/libmachista-test.c:25` || 35 35 || `AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK` || `src/darwintracelib1.0/darwintrace.c:1029` ||