Changes between Version 25 and Version 26 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 7, 2013, 12:27:55 AM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v25 v26  
    3535|| `AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK` || `src/darwintracelib1.0/darwintrace.c:1029` || `if (lstat(path, &sb) == 0) {` || condition for checking symlinks || `/* for symlinks, we want to capture both the original path and the modified one, since for /usr/bin/gcc -> gcc-4.0, both "gcc_select" and "gcc" are contributors */` Checking for this with `autoconf` could also help with things related to #39850 and stuff... ||
    3636|| `AC_FUNC_MALLOC` || `src/cregistry/entry.c:88` || `reg_entry* e = malloc(sizeof(reg_entry));` || does some sqlite3 conversion for the registry || `malloc`-ing is just one of those things you should be checking anyways; I'm surprised the `configure` script doesn't already do this... ||
    37 || `AC_FUNC_MMAP` || `src/machista1.0/libmachista.c:469` ||
    38 || `AC_FUNC_REALLOC` || `src/cregistry/util.c:56` ||
    39 || `AC_PROG_AWK` || `portmgr/packaging/buildall.sh:44` ||
    40 || `AC_PROG_RANLIB` || `src/cregistry/Makefile:5` ||
     37|| `AC_FUNC_MMAP` || `src/machista1.0/libmachista.c:469` || `if ((data = mmap(NULL, st.st_size, PROT_READ, MAP_FILE | MAP_PRIVATE, fd, 0)) == MAP_FAILED) {` || in mach-o file parser || `/* Map file into address space */` Checking how `mmap` works would be good for this. ||
     38|| `AC_FUNC_REALLOC` || `src/cregistry/util.c:56` || `new_dst = realloc(*dst, *dst_space * sizeof(char) + 1);` || in concatenation function || Again, memory management is just one of those things you check. ||
     39|| `AC_PROG_AWK` || `portmgr/packaging/buildall.sh:44` || `mysz=\`cd /; du -sk $i |awk '{print $1}'\`` || used in making chroot disk image || MacPorts actually uses `awk` in a lot of places; this should probably be given a value (one that gets substituted in) in `mk/macports.autoconf.mk.in` and then in either `src/port1.0/port_autoconf.tcl.in` or `src/macports1.0/macports_autoconf.tcl.in` (or both), as well. ||
     40|| `AC_PROG_RANLIB` || `src/cregistry/Makefile:5` || `RANLIB = ranlib` || variable definition || this should be substituted in by the `configure` script instead of set manually ||
    4141|| `AC_TYPE_MODE_T` || `src/darwintracelib1.0/darwintrace.c:963` ||
    4242|| `AC_TYPE_OFF_T` || `src/pextlib1.0/flock.c:57` ||