Changes between Version 26 and Version 27 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 7, 2013, 12:36:27 AM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v26 v27  
    3737|| `AC_FUNC_MMAP` || `src/machista1.0/libmachista.c:469` || `if ((data = mmap(NULL, st.st_size, PROT_READ, MAP_FILE | MAP_PRIVATE, fd, 0)) == MAP_FAILED) {` || in mach-o file parser || `/* Map file into address space */` Checking how `mmap` works would be good for this. ||
    3838|| `AC_FUNC_REALLOC` || `src/cregistry/util.c:56` || `new_dst = realloc(*dst, *dst_space * sizeof(char) + 1);` || in concatenation function || Again, memory management is just one of those things you check. ||
    39 || `AC_PROG_AWK` || `portmgr/packaging/buildall.sh:44` || `mysz=\`cd /; du -sk $i |awk '{print $1}'\`` || used in making chroot disk image || MacPorts actually uses `awk` in a lot of places; this should probably be given a value (one that gets substituted in) in `mk/macports.autoconf.mk.in` and then in either `src/port1.0/port_autoconf.tcl.in` or `src/macports1.0/macports_autoconf.tcl.in` (or both), as well. ||
     39|| `AC_PROG_AWK` || `portmgr/packaging/buildall.sh:44` || `mysz=$(cd /; du -sk $i |awk '{print $1}')` || used in making chroot disk image || MacPorts actually uses `awk` in a lot of places; this should probably be given a value (one that gets substituted in) in `mk/macports.autoconf.mk.in` and then in either `src/port1.0/port_autoconf.tcl.in` or `src/macports1.0/macports_autoconf.tcl.in` (or both), as well. ||
    4040|| `AC_PROG_RANLIB` || `src/cregistry/Makefile:5` || `RANLIB = ranlib` || variable definition || this should be substituted in by the `configure` script instead of set manually ||
    41 || `AC_TYPE_MODE_T` || `src/darwintracelib1.0/darwintrace.c:963` ||
    42 || `AC_TYPE_OFF_T` || `src/pextlib1.0/flock.c:57` ||
     41|| `AC_TYPE_MODE_T` || `src/darwintracelib1.0/darwintrace.c:963` || `mode_t mode;` || used in wrapper for the `open` function || `/* wrapper for open(2) preventing opening files outside the sandbox */` Since it uses the `mode_t` type in it, this should be checked for ||
     42|| `AC_TYPE_OFF_T` || `src/pextlib1.0/flock.c:57` || `off_t curpos;` || in an `ifdef`: `#if defined(HAVE_LOCKF) && !defined(HAVE_FLOCK)` || It wouldn't be too much more to ask to add another condition to this `#if`: just a simple `&& defined(HAVE_OFF_T)` would do ||
    4343|| `AC_TYPE_PID_T` || `src/darwintracelib1.0/darwintrace.c:134` ||
    4444|| `AC_TYPE_SIZE_T` || `src/cregistry/entry.c:376` ||