Changes between Version 27 and Version 28 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 7, 2013, 12:52:03 AM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v27 v28  
    2929|| `AC_CHECK_HEADERS([sys/time.h])` || `src/pextlib1.0/sha2.c:38` || `#include <sys/time.h>` || an included header || something useful ||
    3030|| `AC_CHECK_HEADER_STDBOOL` || `src/machista1.0/libmachista.c:247` || `bool universal = false;` || In a mach-o parsing function || `/* Parse the Mach-O header */` I do not get why `autoscan` says this macro is needed for this line instead of line 33 which has the actual `#include <stdbool.h>` on it, but whatever... ||
    31 || `AC_C_INLINE` || `src/darwintracelib1.0/darwintrace.c:117` || `static inline int __darwintrace_strbeginswith(const char *str, const char *prefix);` || looks like a function prototype? || not sure why this uses `inline` (it looks like regular C to me), but if we're going to be using `inline` stuff, it'd probably be a good idea to have `autoconf` check how the compiler handles it... (also throw in the `AC_C_PROTOTYPES` macro in there while you're at it) ||
     31|| `AC_C_INLINE` || `src/darwintracelib1.0/darwintrace.c:117` || `static inline int __darwintrace_strbeginswith(const char *str, const char *prefix);` || looks like a global variable? || not sure why this uses `inline` (it looks like regular C to me), but if we're going to be using `inline` stuff, it'd probably be a good idea to have `autoconf` check how the compiler handles it... ||
    3232|| `AC_C_RESTRICT` || `src/darwintracelib1.0/darwintrace.c:774` || `static void frecv(void *restrict buf, size_t size) {` || function declaration || `/* Helper function to recieve a number of bytes from the tracelib communication socket and deal with any errors that might occur. */` Using `restrict` can be good for performance, have `autoconf` check how the compiler handles it to make sure ||
    3333|| `AC_FUNC_CHOWN` || `src/pextlib1.0/xinstall.c:1077` || `if ((gid != (gid_t)-1 || uid != (uid_t)-1) && chown(path, uid, gid))` || in a condition || Helps build the directory "`heirarchy` [sic]". Plus checking how `chown`ing works is probably a good idea anyways. ||
    … …  
    4141|| `AC_TYPE_MODE_T` || `src/darwintracelib1.0/darwintrace.c:963` || `mode_t mode;` || used in wrapper for the `open` function || `/* wrapper for open(2) preventing opening files outside the sandbox */` Since it uses the `mode_t` type in it, this should be checked for ||
    4242|| `AC_TYPE_OFF_T` || `src/pextlib1.0/flock.c:57` || `off_t curpos;` || in an `ifdef`: `#if defined(HAVE_LOCKF) && !defined(HAVE_FLOCK)` || It wouldn't be too much more to ask to add another condition to this `#if`: just a simple `&& defined(HAVE_OFF_T)` would do ||
    43 || `AC_TYPE_PID_T` || `src/darwintracelib1.0/darwintrace.c:134` ||
     43|| `AC_TYPE_PID_T` || `src/darwintracelib1.0/darwintrace.c:134` || `static pid_t __darwintrace_pid = (pid_t) - 1;` || global variable? || `darwintrace` (and `daemondo`, too, for that matter) uses `pid`s extensively; check to see how they work ||
    4444|| `AC_TYPE_SIZE_T` || `src/cregistry/entry.c:376` ||
    4545|| `AC_TYPE_SSIZE_T` || `src/darwintracelib1.0/darwintrace.c:996` ||