Changes between Version 32 and Version 33 of Ticket #38582, comment 6
- Timestamp:
- Aug 7, 2013, 2:07:55 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #38582, comment 6
v32 v33 1 1 I don't think any of these macros can actually fail, so I don't see why they'd need fallback code. They're just for adding more information about the user's system to their `config.log` and to their `src/config.h` ~~(which I guess MacPorts doesn't use, but it could do so easily...)~~ and to the various other files that `autoconf` substitutes stuff in. Also it looks like a lot of the macros currently in `configure.ac` were originally added with an older version of `autoscan`, this would be just updating those to a more recent version. Anyway I've edited a table into this post showing more about these macros: 2 ||= '''Macro''' =||= '''line of file `autoscan` wants it for''' =||= '''contents of line mentioned in previous column''' =||= '''context (how the line is used)''' =||= '''human explanation for how adding the macro will be useful (i.e. relevant comments)''' =||2 ||= '''Macro''' =||= '''line of file that `autoscan` mentioned it wanted it for in the latest set of warnings it produced''' =||= '''contents of line mentioned in previous column''' =||= '''context (how the line is used)''' =||= '''human explanation for how adding the macro will be useful (i.e. relevant comments)''' =|| 3 3 || `AC_CHECK_FUNCS([dup2])` || `src/darwintracelib1.0/darwintrace.c:1100` || `int dup2(int filedes, int filedes2) {` || new function declaration || `/* if darwintrace has been initialized, trap attempts to dup2 over our file descriptor */` (this function would only be useful if calls are being made to `dup2` in the first place, so check for it) || 4 4 || `AC_CHECK_FUNCS([getcwd])` || `src/darwintracelib1.0/darwintrace.c:642` || `if (!getcwd(somepath, sizeof(somepath))) {` || condition for an error message || In a path-sending function. Checking for `getcwd` would ensure that this function works. ||