Changes between Version 33 and Version 34 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 7, 2013, 2:20:59 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v33 v34  
    1212|| `AC_CHECK_FUNCS([rmdir])` || `src/darwintracelib1.0/darwintrace.c:1183` || `int rmdir(const char *path) {` || new function declaration || `/* Trap attempts to remove directories outside the sandbox. */` Make sure there are calls to `rmdir` to trap in the first place ||
    1313|| `AC_CHECK_FUNCS([setenv])` || `src/pextlib1.0/Pextlib.c:409` || `setenv("MACPORTS_DUMMY", "", 0);` || Inside an `#ifndef __APPLE__` for Linux environments. || `/* Crashes on Linux without this. */` Seeing as this test is for Linux anyways, and Linux is easier to break than OS X is, and it is already inside an `#ifndef`, the condition could easily be modified to check for `HAVE_SETENV` as well. ||
    14 || `AC_CHECK_FUNCS([socket])` || `src/darwintracelib1.0/darwintrace.c:589` || `if (-1 == (sock = socket(PF_LOCAL, SOCK_STREAM, 0))) {` || inside the part where `darwintrace` sets itself up || I actually do not really get what is going on here, but it would probably just be good to check for the `socket` function anyways. ||
     14|| `AC_CHECK_FUNCS([socket])` || `src/darwintracelib1.0/darwintrace.c:589` || `if (-1 == (sock = socket(PF_LOCAL, SOCK_STREAM, 0))) {` || inside the part where `darwintrace` sets itself up || cal says that "darwintrace embeds itself in every process executed from a portfile and connects to a unix socket created by macports when trace mode is enabled", so checking the `socket` function would be good just to help make sure that this will work properly. ||
    1515|| `AC_CHECK_FUNCS([strchr])` || `src/machista1.0/machista_wrap.c:1381` || `char* where = strchr(cr,':');` || I actually have no clue what is going on here; there are very few comments in this area of the code... || Even though I do not really get what this is used for here, it would still probably be a good idea to check for `strchr` for this anyways. ||
    1616|| `AC_CHECK_FUNCS([strdup])` || `src/cregistry/entry.c:384` || `query = strdup("SELECT id FROM registry.ports");` || In a registry searching function || `/* build the query */` Checking for `strdup` for this would help ensure that registry-checking works properly. ||