Changes between Version 34 and Version 35 of Ticket #38582, comment 6


Ignore:
Timestamp:
Aug 7, 2013, 2:23:25 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v34 v35  
    1616|| `AC_CHECK_FUNCS([strdup])` || `src/cregistry/entry.c:384` || `query = strdup("SELECT id FROM registry.ports");` || In a registry searching function || `/* build the query */` Checking for `strdup` for this would help ensure that registry-checking works properly. ||
    1717|| `AC_CHECK_FUNCS([strerror])` || `src/macports1.0/sysctl.c:72` || `Tcl_AppendObjToObj(tcl_result, Tcl_NewStringObj(strerror(errno), -1));` || Used for an error that can result from checking `sysctl` || Checking for `strerror` for this could improve `sysctl` checking. ||
    18 || `AC_CHECK_FUNCS([strrchr])` || `src/darwintracelib1.0/darwintrace.c:894` || `char *lastSep = strrchr(normalizedpath, '/');` || Helps check paths against the sandbox || `/* walk up one directory */` Checking for `strrchr` for this could help with sandboxing, which currently has some issues: #39850 for example ||
     18|| `AC_CHECK_FUNCS([strrchr])` || `src/darwintracelib1.0/darwintrace.c:894` || `char *lastSep = strrchr(normalizedpath, '/');` || Helps check paths against the sandbox || `/* walk up one directory */` Checking for `strrchr` for this could help with sandboxing, which currently has some issues: #39850 for example. It would also be good just to check the `strrchr` function anyways; it can't hurt... ||
    1919|| `AC_CHECK_FUNCS([strstr])` || `src/machista1.0/machista_wrap.c:1383` || `where = strstr(where, meth->name);` || idk || I don't get this file; just check the `strstr` function anyways... ||
    2020|| `AC_CHECK_FUNCS([strtol])` || `src/pextlib1.0/Pextlib.c:206` || `pwent = getpwuid(strtol(user, 0, 0));` || in the `ExistsuserCmd` function || There is no commentary around this, but it would probably be a good idea to check for the `strtol` function anyways... ||