Changes between Version 3 and Version 4 of Ticket #38582, comment 6


Ignore:
Timestamp:
Jul 30, 2013, 8:20:58 PM (11 years ago)
Author:
cooljeanius (Eric Gallager)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #38582, comment 6

    v3 v4  
    11I don't think any of these macros can actually fail, so I don't see why they'd need fallback code. They're just for adding more information about the user's system to their `config.log` and to their `config.h` (which I guess MacPorts doesn't use, but it could do so easily...). Also it looks like a lot of the macros currently in `configure.ac` were originally added with an older version of `autoscan`, this would be just updating those to a more recent version. Anyway I'm planning on editing a table into this post showing more about these macros:
    2 ||= Macro =||= line of file `autoscan` wants it for =||= contents of line from previous column =||= context (how the line is used) =||= human explanation for how adding the macro will be useful (i.e. relevant comments) =||
    3 ||= `AC_CHECK_FUNCS([dup2])` =||= `src/darwintracelib1.0/darwintrace.c:1100` =||= `int dup2(int filedes, int filedes2) {` =||= new function declaration =||= `/* if darwintrace has been initialized, trap attempts to dup2 over our file descriptor */` (this function would only be useful if calls are being made to `dup2` in the first place, so check for it) =||
    4 ||= `AC_CHECK_FUNCS([getcwd])` =||= `src/darwintracelib1.0/darwintrace.c:642` =||= `if (!getcwd(somepath, sizeof(somepath))) {` =||= condition for an error message =||= In a path-sending function. Checking for `getcwd` would ensure that this function works. =||
    5 ||= `AC_CHECK_FUNCS([lchown])` =||= `src/pextlib1.0/Pextlib.c:465` =||= ` if (lchown(path, (uid_t) user, (gid_t) group) != 0) {` =||= condition for a Tcl error =||= part of an overall Tcl wrapper around `lchown`. Checking for this function would ensure that there's actually something to have a wrapper around in the first place. =||
    6 ||= `AC_CHECK_FUNCS([localtime_r])` =||= `src/programs/daemondo/main.c:128` =||= `strftime(datestring, sizeof(datestring), "%F %T", localtime_r(&timestamp, &tm));` =||= In a log message function =||= `// Format the date-time stamp` (checking for this function would ensure that the log messages have properly formatted timestamps) =||
     2||= '''Macro''' =||= '''line of file `autoscan` wants it for''' =||= '''contents of line mentioned in previous column''' =||= '''context (how the line is used)''' =||= '''human explanation for how adding the macro will be useful (i.e. relevant comments)''' =||
     3|| `AC_CHECK_FUNCS([dup2])` || `src/darwintracelib1.0/darwintrace.c:1100` || `int dup2(int filedes, int filedes2) {` || new function declaration || `/* if darwintrace has been initialized, trap attempts to dup2 over our file descriptor */` (this function would only be useful if calls are being made to `dup2` in the first place, so check for it) ||
     4|| `AC_CHECK_FUNCS([getcwd])` || `src/darwintracelib1.0/darwintrace.c:642` || `if (!getcwd(somepath, sizeof(somepath))) {` || condition for an error message || In a path-sending function. Checking for `getcwd` would ensure that this function works. ||
     5|| `AC_CHECK_FUNCS([lchown])` || `src/pextlib1.0/Pextlib.c:465` || ` if (lchown(path, (uid_t) user, (gid_t) group) != 0) {` || condition for a Tcl error || part of an overall Tcl wrapper around `lchown`. Checking for this function would ensure that there's actually something to have a wrapper around in the first place. ||
     6|| `AC_CHECK_FUNCS([localtime_r])` =||= `src/programs/daemondo/main.c:128` || `strftime(datestring, sizeof(datestring), "%F %T", localtime_r(&timestamp, &tm));` || In a log message function || `// Format the date-time stamp` (checking for this function would ensure that the log messages have properly formatted timestamps) ||
    77
    88(coming back to this later...)