Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#39006 closed defect (fixed)

OpenSceneGraph @3.0.1 Runtime error - infinite recursion on sinf

Reported by: Eduardop Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc: mkae (Marko Käning), cooljeanius (Eric Gallager)
Port: OpenSceneGraph

Description

The OpenSceneGraph port has a runtime infinite recursion bug when the function sinf is called, as well as other math functions. This is described here:

http://forum.openscenegraph.org/viewtopic.php?t=9121

I prepared the attached fix.

Attachments (2)

patch-include-osg-Math.diff (544 bytes) - added by Eduardop 12 years ago.
Patch for OpenSceneGraph - file updated
Portfile-OpenSceneGraph.diff (749 bytes) - added by Eduardop 12 years ago.
Patch for OpenSceneGraph's portfile

Download all attachments as: .zip

Change History (16)

comment:1 Changed 12 years ago by larryv (Lawrence Velázquez)

Keywords: haspatch added; sinf recursion removed

Changed 12 years ago by Eduardop

Attachment: patch-include-osg-Math.diff added

Patch for OpenSceneGraph - file updated

comment:2 Changed 12 years ago by Eduardop

Updated with the proper patch-include-osg-Math.diff​ file, sorry about the mistake.

comment:3 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

If this is not a build error, but a runtime error, then the revision must be increased so that existing users are prompted to upgrade.

comment:4 in reply to:  3 ; Changed 12 years ago by Eduardop

There is no "revision" line in the Portfile, should one be added?

comment:5 in reply to:  4 Changed 12 years ago by larryv (Lawrence Velázquez)

Replying to poyart@…:

There is no "revision" line in the Portfile, should one be added?

Yes, and set it to “1”.

Changed 12 years ago by Eduardop

Patch for OpenSceneGraph's portfile

comment:6 Changed 12 years ago by Eduardop

Patch updated, revision line added.

comment:7 Changed 12 years ago by mkae (Marko Käning)

Resolution: fixed
Status: newclosed

Done in r106211

comment:8 Changed 12 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:9 Changed 12 years ago by mkae (Marko Käning)

Resolution: fixed
Status: closedreopened

After having built the software I only now manage to test it, but I seem to be unable to let it open up a display window:

$ osgviewer robot.osg 
View::setUpViewAcrossAllScreens() : Error, no WindowSystemInterface available, cannot create windows.
Viewer::realize() - failed to set up any windows
View::setUpViewAcrossAllScreens() : Error, no WindowSystemInterface available, cannot create windows.
Viewer::realize() - failed to set up any windows

Any idea what I am missing?

comment:10 Changed 12 years ago by mf2k (Frank Schima)

What windowing system is it supposed to use? Given the license, it would seem to be wxWidgets, yet there is no dependency on it. Maybe a dependency on wxWidgets30 would be useful. Also the port may need to be modified to recognize it.

comment:11 Changed 12 years ago by mkae (Marko Käning)

robot.osg is one of the many test files from OSG's standard test files downloaded from its website at

http://www.openscenegraph.org/downloads/stable_releases/OpenSceneGraph-3.0/data/OpenSceneGraph-Data-3.0.0.zip

comment:12 Changed 12 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:13 Changed 11 years ago by Eduardop

The error described in comment #9 can be fixed by building with:

sudo port install openscenegraph configure.args="-DOSG_WINDOWING_SYSTEM=Cocoa"

Is there a way to make that option be the default?

Also, this bug is related to the sinf error. This is a different problem. Maybe the sinf bug should be closed and another one opened.

Version 0, edited 11 years ago by Eduardop (next)

comment:14 Changed 11 years ago by mkae (Marko Käning)

Resolution: fixed
Status: reopenedclosed

Thanks for the hint, poyart!

Done in r106454

Note: See TracTickets for help on using tickets.