Opened 11 years ago
Closed 9 years ago
#39383 closed enhancement (fixed)
Ports with a no_x11 variant should be changed to use x11
Reported by: | mf2k (Frank Schima) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt), julians37@…, reiffert@…, rene@…, dbevans (David B. Evans), takanori@…, mpal1+bugzilla@…, mojca (Mojca Miklavec), rmstonecipher@…, gwright@…, neverpanic (Clemens Lang), rowue@…, yeti@…, mkae (Marko Käning), pixilla (Bradley Giesbrecht), jmroot (Joshua Root), filippo.natali@…, ddennedy (Dan Dennedy), raphael-st (Raphael Straub), MarcusCalhoun-Lopez (Marcus Calhoun-Lopez), nefar@…, tenomoto (Takeshi Enomoto), shreevatsa.public@…, drkp (Dan Ports), Liontooth (David Liontooth), opendarwin.org@…, cooljeanius (Eric Gallager) | |
Port: |
Description (last modified by mojca (Mojca Miklavec))
Per Macports policy against no_foo variant names, all ports with a +no_x11
variant should be changed to use +x11
instead. The dependencies and code will need to be reversed in most cases.
Some ports have no_x11
as a legacy variant, which should be retained for one year and then it can be removed.
Here's a list:
Ports with x11 only/fixed
- at-spi (nomaintainer) -
no_x11
removed in r106775. - basiliskii-devel (nomaintainer) -
gtk
since r115460 / r115462 2014-01-02,no_x11
removed in r134348. - cairo-devel (ryandesign) -
x11
since r78848 2011-05-24,no_x11
removed in r111805. - darktable (gmail.com:julians37) -
x11
since r75631 2011-02-01;no_x11
has never been a compatibility variant.no_x11
removed in r118500, r118501. - efte (reiffert, open) -
x11
since r115028 2013-12-22,no_x11
removed in r142118 - gd2 (ryandesign) -
x11
since r109413 2013-08-14,no_x11
removed in r142115 - gedit (devans, open) -
no_x11
removed in r106998. - giflib (ryandesign) -
x11
since r93239 2012-05-17,no_x11
removed in r115523. - ghostscript (takanori, open) -
no_x11
removed in r112515. - ghostscript-fonts-hiragino (takanori, open) -
no_alias
removed in r112516. - gnokii (ieee.org:mpal1+bugzilla) -
x11
since r119749 2014-05-05,no_x11
removed in r142120 - gnome-sharp2 (nomaintainer) -
x11
since r107104 2013-06-18,no_x11
removed in r121925 - gnuplot (mojca, open) -
x11
since r96459 2012-08-10,no_x11
removed in r108795. - graphviz & graphviz-devel (ryandesign) -
x11
since r102579 2013-02-04,no_x11
andno_pangocairo
removed in r121932 - gromacs & gromacs-double (nomaintainer) -
x11
since r108345 2013-07-20,no_x11
removed in r123374 - gstreamer010-gst-plugins-bad (rmstonecipher, open) -
no_x11
removed in r119678. - gstreamer010-gst-plugins-base (rmstonecipher, open) -
gnome_vfs
x11
andogg
added in r119724 2014-05-04,no_x11
,no_ogg
,no_gnome_vfs
removed in r142117 - gstreamer1-gst-plugins-bad (rmstonecipher, open) -
no_x11
removed in r113908. - gstreamer1-gst-plugins-base (rmstonecipher, open)
x11
andogg
added in r113914 2013-11-25,no_x11
andno_ogg
removed in r131952 - gtk2 (nomaintainer) -
x11
changes since r103155 2013-02-16, variant existed earlier.no_x11
removed in r118503. - gtk3 (cal, open) -
x11
changes since r103160 2013-02-16, variant existed earlier.no_x11
removed in r118504. - gwyddion (rowue, open) - +quartz since r108367 2013-07-21.
no_x11
removed in r128218. - ImageMagick (ryandesign) -
x11
since r106049 2013-05-13,no_x11
removed in r121931 - kmymoney4 (mk, pixilla, open) removed in r110987
- kmymoney4-devel (mk, pixilla, open) removed in r110986
- libbonoboui (nomaintainer) -
x11
since r107293 2013-06-25,no_x11
removed in r121921 - libgnomekbd (devans, open) -
x11
since r107083 2013-06-17,no_x11
removed in r121924 - libgnomeui (nomaintainer) -
x11
since r107294 2013-06-25,no_x11
removed in r121919 - libmpeg2 (nomaintainer) -
x11
since r118506, r118542 2014-04-03,no_x11
removed in r134351. - libsdl (jmr, open) -
x11
since r78823 2011-05-23.no_x11
removed in r109316. - libunique (devans, open) -
x11
since r107051 2013-06-16,no_x11
removed in r121927 - mjpegtools (gmail.com:filippo.natali) -
x11
since r87467 2011-11-22.no_x11
removed in r118502. - mlt (dennedy.org:dan) - Probably should be called
+gtk2
instead and reversed.no_x11
removed in r110684. - mpeg2vidcodec (nomaintainer).
x11
added in r110736 2013-09-04,no_x11
removed in r134349 - openssh (nomaintainer) -
+xauth
since r108465 2013-07-23,no_x11
removed in r123375 - openvrml (raphael, open) -
x11
since r82212 and r82194 2011-08-10.no_x11
andno_opengl
removed in r110726. - pgplot (mcalhoun, open) -
x11
since r110730 2013-09-04,no_x11
removed in r142116 - pidgin (devans, open) -
x11
since r119699 2014-05-03,no_x11
removed in r142119 - plplot & plplot-single (takeshi, open) -
x11
since r99946 2012-11-21,no_x11
removed in r108600. - pTeX (takanori, open) (also has
no_hiragino
,no_otf
,no_x11
) removed in r111190. - sheepshaver (nomaintainer) -
+gtk
since r115661 2014-01-08 (see #30672, port broken);no_x11
removed in r134350. - surf (gmail.com:shreevatsa.public, open) -
gui
added,no_x11
removed in r119755 2014-05-05 (#43582) - texlive-bin (dports) -
x11
since r82097 2011-08-07,no_x11
removed in r108863. - transcode (cogweb.net:lionteeth, devans)
- wireshark (darkart.com:opendarwin.org) -
x11
since r119784 2014-05-06,no_x11
removed in the same commit (compare with wireshark-devel, also dasno_adns, no_geoip, no_gnutls, no_ipv6, no_libgcrypt, no_libsmi, no_lua, no_rtp, no_ssl, no_x11
) – replacing it with what's now inwireshark-devel
and using Qt in version 1.11.x/1.12.x might eliminate the need forx11
altogether
Broken:
Change History (57)
comment:1 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
comment:3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to macsforever2000@…:
Some ports have no_x11 as a legacy variant, but I don't see a reason to keep them around since they do nothing.
The no_x11 legacy variants exist so that users who had previously selected those variants will continue to have X11 disabled after upgrading. All ports that are converted from no_x11 to x11 variants should maintain such a no_x11 legacy variant for one year so that users upgrading the ports do not suddenly receive features they specifically requested not to receive.
comment:4 Changed 11 years ago by mojca (Mojca Miklavec)
While I'm ready to patch at any time - what about the rule that "updates are supposed to run smoothly for a year after the change"?
Gnuplot introduced the option +x11 in August 2012 (r96459). If there is anyone who installed gnuplot with +no_x11 back in July 2012, the update won't go as expected.
While this is hardly a problem for gnuplot (it's been 10 months now which is almost a year): aren't there going to be problems in other packages if an option is simply removed without any grace period?
PS: I'm sorry. I only noticed now that Ryan actually said the same thing. I didn't see his post earlier.
comment:5 Changed 11 years ago by mojca (Mojca Miklavec)
Here's a grouped list created out of the list above. I didn't check if any other ports contain [no_]x11
, I didn't check ports for which it says "remove legacy no_x11
", but I checked if any port added +x11
recently.
If anyone wants or agrees with the list, it can be moved to the top description and updates as work proceeds, I didn't dare to do that.
Ports without x11 variant:
Ports with no maintainer:
- libmpeg2 (nomaintainer) (also
no_sdl
) - mpeg2vidcodec (nomaintainer)
- nessus-core (nomaintainer)
- openssh (nomaintainer)
Ports with open maintainer:
- efte (reiffert, open)
- ghostscript (takanori, open)
- gstreamer1-gst-plugins-bad (rmstonecipher, open)
- gstreamer1-gst-plugins-base (rmstonecipher, open) (also
no_gnome_vfs, no_ogg
) - gstreamer010-gst-plugins-bad (rmstonecipher, open)
- gstreamer010-gst-plugins-base (rmstonecipher, open) (also
no_gnome_vfs, no_ogg
) - kmymoney4 (mk, pixilla, open) (also
no_gtk
) - kmymoney4-devel (mk, pixilla, open) (also
no_gtk
) - pgplot (mcalhoun, open)
- pTeX (takanori, open) (also has
no_hiragino, no_otf, no_x11
) - surf (gmail.com:shreevatsa.public, open)
Other ports:
- basiliskii-devel (vercruesse.de:opendarwin.nospam)
- gajim-devel (rene)
- gnokii (ieee.org:mpal1+bugzilla)
- gtk2hs (gwright)
- gwyddion (rowue, gwyddion.net:yeti) - Probably could be simply be renamed to +quartz
- mlt (dennedy.org:dan) - Probably should be called +gtk2 instead and reversed
- pidgin (otherware.org:nefar)
- sheepshaver (vercruesse.de:opendarwin.nospam)
- wireshark (darkart.com:opendarwin.org) (compare with wireshark-devel, also has
no_adns, no_geoip, no_gnutls, no_ipv6, no_libgcrypt, no_libsmi, no_lua, no_rtp, no_ssl, no_x11
)
Ports with both x11 and no_x11:
- cairo-devel (ryandesign)
- darktable (gmail.com:julians37)
- gd2 (ryandesign) - (version 2.1 has
x11
) - giflib (ryandesign)
- gnome-sharp2 (nomaintainer)
- gnuplot (mojca, open) -
x11
added on 2012-08-10 - graphviz (ryandesign)
- graphviz-devel (ryandesign)
- gromacs & gromacs-double (nomaintainer) -
x11
added on 2013-07-20 - gtk2 (nomaintainer)
- gtk3 (cal, open)
- ImageMagick (ryandesign)
- libbonoboui (nomaintainer)
- libgnomekbd (devans, open)
- libgnomeui (nomaintainer)
- libsdl (jmr, open)
- libunique (devans, open)
- mjpegtools (gmail.com:filippo.natali)
- openvrml (raphael, open)
- plplot (takeshi, open)
- plplot-single (takeshi, open)
- texlive-bin (dports)
Ports with x11 only/fixed
- transcode (cogweb.net:lionteeth, devans)
I don't find any x11
at-spi (nomaintainer)- gedit (devans, open)
comment:7 Changed 11 years ago by larryv (Lawrence Velázquez)
Description: | modified (diff) |
---|
comment:9 follow-up: 10 Changed 11 years ago by mirimiri66@…
Regarding openssh; Now that no_x11 has been removed, how can xorg components be prevented from installing?
port -y upgrade openssh -xauth
doesn't seem to work.
comment:10 follow-up: 13 Changed 11 years ago by neverpanic (Clemens Lang)
Replying to mirimiri66@…:
port -y upgrade openssh -xauth
doesn't seem to work.
Try port upgrade --enforce-variants openssh -xauth
. I should probably have added --without-xauth
to make sure, though.
comment:12 Changed 11 years ago by larryv (Lawrence Velázquez)
Description: | modified (diff) |
---|
comment:13 follow-up: 14 Changed 11 years ago by mirimiri66@…
Replying to cal@…:
Replying to mirimiri66@…:
port -y upgrade openssh -xauth
doesn't seem to work.Try
port upgrade --enforce-variants openssh -xauth
. I should probably have added--without-xauth
to make sure, though.
It still pulls in xorg components.
comment:14 Changed 11 years ago by neverpanic (Clemens Lang)
Replying to mirimiri66@…:
It still pulls in xorg components.
Please file a separate bug for this an cc me, if it still persists. Attach the main.log
and explain how it "pulls in xorg components". I cannot reproduce and the dependency list of openssh -xauth (port rdeps openssh -xauth
) seems to correctly reflect the variant.
comment:15 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | at-spi gedit gnuplot plplot plplot-single transcode removed |
comment:16 Changed 11 years ago by drkp (Dan Ports)
Removed the compatibility variant from texlive-bin in r108863.
comment:17 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
comment:18 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | texlive-bin removed |
comment:19 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
Removed from libsdl in r109316 by jmr.
comment:20 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
comment:21 Changed 11 years ago by mf2k (Frank Schima)
Cc: | opendarwin.nospam@… removed |
---|---|
Description: | modified (diff) |
Per email, basiliskii-devel and sheepshaver are no longer being maintained by vercruesse.de:opendarwin.nospam.
comment:22 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
cal removed no_x11 from mlt in r110684.
comment:23 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
no_x11 and no_opengl removed from openvrml in r110726.
comment:24 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:25 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
added x11 to mpeg2vidcodec in r110736.
comment:26 Changed 11 years ago by mkae (Marko Käning)
Description: | modified (diff) |
---|
comment:27 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
pTeX fixed in r111190.
comment:28 Changed 11 years ago by takanori@…
Description: | modified (diff) |
---|
ghostscript fixed in r112515
comment:29 Changed 11 years ago by takanori@…
Description: | modified (diff) |
---|
ghostscript-fonts-hiragino fixed in r112516
comment:30 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:31 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | cairo-devel gajim-devel ghostscript gstreamer1-gst-plugins-bad gstreamer1-gst-plugins-base kmymoney4 kmymoney4-devel libsdl mlt openvrml pTeX removed |
gajim-devel
port doesn't exist any longercairo-devel
,gstreamer1-gst-plugins-bad
no longer containno_x11
, removed from list of portsgstreamer1-gst-plugins-base
now hasx11
ghostscript
,kmymoney4
,kmymoney4-devel
,libsdl
,mlt
,openvrml
,pTeX
removed from list of ports (they no longer containno_x11
)
comment:32 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:33 Changed 11 years ago by mojca (Mojca Miklavec)
I attached a Portfile
for sheepshaver
to #30672. The problem is that the compilation is broken. What do you think about committing the patch nevertheless?
comment:34 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | giflib removed |
comment:35 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:37 Changed 11 years ago by mojca (Mojca Miklavec)
- libmpeg2 (nomaintainer) –
+x11
since r118506 2014-04-03
comment:39 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
comment:40 Changed 11 years ago by dbevans (David B. Evans)
Description: | modified (diff) |
---|---|
Port: | gstreamer010-gst-plugins-bad removed |
gstreamer010-gst-plugins-bad: no_x11
removed in r119678.
comment:41 Changed 11 years ago by dbevans (David B. Evans)
Description: | modified (diff) |
---|
pidgin: +x11
added in r119699.
comment:42 Changed 11 years ago by dbevans (David B. Evans)
Description: | modified (diff) |
---|
gstreamer010-gst-plugins-base: gnome_vfs
x11
and ogg
added in r119724
comment:43 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | darktable graphviz graphviz-devel gtk2 gtk3 mjpegtools removed |
surf
doesn't build withoutx11
(see #43582)- I removed
darktable
,graphviz
,graphviz-devel
,gtk2
,gtk3
,mjpegtools
from the list of affected ports (Ryan, can you please removeno_x11
fromgraphviz[-devel]
?)
Only 6 more ports to go ...
comment:44 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
gnokii
:x11
added in r119749 (2014-05-05)
Only 5 more ports to go ...
comment:45 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:46 Changed 11 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | surf removed |
comment:47 Changed 11 years ago by cooljeanius (Eric Gallager)
wireshark was done in r119784 (although it looks like it might need some other changes, too...)
comment:48 Changed 10 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | nessus-core wireshark removed |
comment:49 Changed 10 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | gnome-sharp2 ImageMagick libbonoboui libgnomekbd libgnomeui libunique removed |
- libgnomeui (nomaintainer) -
no_x11
removed in r121919 - libbonoboui (nomaintainer) -
no_x11
removed in r121921 - libgnomekbd (devans, open) -
no_x11
removed in r121924 - gnome-sharp2 (nomaintainer) -
no_x11
removed in r121925 - libunique (devans, open) -
no_x11
removed in r121927 - ImageMagick (ryandesign) -
no_x11
removed in r121931 - graphviz & graphviz-devel (ryandesign) -
no_x11
andno_pangocairo
removed in r121932
comment:50 Changed 10 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:51 Changed 10 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | gromacs gromacs-double removed |
comment:52 Changed 10 years ago by mojca (Mojca Miklavec)
Port: | openssh removed |
---|
comment:53 Changed 10 years ago by rowue@…
Description: | modified (diff) |
---|---|
Port: | gwyddion removed |
- gwyddion: no_x11 removed in r128218
comment:54 Changed 10 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | basiliskii-devel libmpeg2 mpeg2vidcodec sheepshaver removed |
comment:55 Changed 9 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | efte gd2 gnokii gstreamer010-gst-plugins-base pgplot pidgin removed |
comment:56 Changed 9 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|---|
Port: | gtk2hs removed |
- gtk2hs - r142121
comment:57 Changed 9 years ago by mojca (Mojca Miklavec)
Resolution: | → fixed |
---|---|
Status: | new → closed |
I'm finally closing this ticket now. I removed all no_x11
and I "fixed" the x11 variants gtk2hs
despite its brokenness.
at-spi: r106775