Opened 11 years ago

Last modified 9 years ago

#39383 closed enhancement

Ports with a no_x11 variant should be changed to use x11 — at Version 25

Reported by: mf2k (Frank Schima) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryandesign@…, julians37@…, reiffert@…, rene@…, devans@…, takanori@…, mpal1+bugzilla@…, mojca@…, rmstonecipher@…, gwright@…, cal@…, rowue@…, yeti@…, mk@…, pixilla@…, jmr@…, filippo.natali@…, dan@…, raphael@…, mcalhoun@…, nefar@…, takeshi@…, shreevatsa.public@…, dports@…, lionteeth@…, opendarwin.org@…, egall@…, mirimiri66@…
Port:

Description (last modified by mf2k (Frank Schima))

Per Macports policy against no_foo variant names, all ports with a +no_x11 variant should be changed to use +x11 instead. The dependencies and code will need to be reversed in most cases.

Some ports have no_x11 as a legacy variant, which should be retained for one year and then it can be removed.

Here's a list:

Ports with no maintainer:

  • basiliskii-devel (nomaintainer) - Should be changed to +gtk
  • libmpeg2 (nomaintainer) (also no_sdl)
  • nessus-core (nomaintainer) - the difference between gtk and x11 not clear, dependencies are broken (#38114)
  • sheepshaver (nomaintainer) - Should be changed to +gtk

Ports with open maintainer:

  • efte (reiffert, open)
  • ghostscript (takanori, open)
  • gstreamer1-gst-plugins-bad (rmstonecipher, open)
  • gstreamer1-gst-plugins-base (rmstonecipher, open) (also no_gnome_vfs, no_ogg)
  • gstreamer010-gst-plugins-bad (rmstonecipher, open)
  • gstreamer010-gst-plugins-base (rmstonecipher, open) (also no_gnome_vfs, no_ogg)
  • kmymoney4 (mk, pixilla, open) (also no_gtk)
  • kmymoney4-devel (mk, pixilla, open) (also no_gtk)
  • pTeX (takanori, open) (also has no_hiragino, no_otf, no_x11)
  • surf (gmail.com:shreevatsa.public, open)

Other ports:

  • gajim-devel (rene)
  • gnokii (ieee.org:mpal1+bugzilla)
  • gtk2hs (gwright)
  • pidgin (otherware.org:nefar)
  • wireshark (darkart.com:opendarwin.org) (compare with wireshark-devel, also has no_adns, no_geoip, no_gnutls, no_ipv6, no_libgcrypt, no_libsmi, no_lua, no_rtp, no_ssl, no_x11)

Ports with both x11 and no_x11 by date:

  • graphviz & graphviz-devel (ryandesign) - x11 since r102579 2013-02-04
  • gtk2 (nomaintainer) - x11 changes since r103155 2013-02-16, variant existed earlier
  • gtk3 (cal, open) - x11 changes since r103160 2013-02-16, variant existed earlier
  • ImageMagick (ryandesign) - x11 since r106049 2013-05-13
  • libunique (devans, open) - x11 since r107051 2013-06-16
  • gnome-sharp2 (nomaintainer) - x11 since r107104 2013-06-18
  • libgnomekbd (devans, open) - x11 since r107083 2013-06-17
  • libbonoboui (nomaintainer) - x11 since r107293 2013-06-25
  • libgnomeui (nomaintainer) - x11 since r107294 2013-06-25
  • gromacs & gromacs-double (nomaintainer) - x11 since r108345 2013-07-20
  • gwyddion (rowue, gwyddion.net:yeti) - +quartz since r108367 2013-07-21
  • openssh (nomaintainer) - +xauth since r108465 2013-07-23
  • gd2 (ryandesign) - x11 since r109413 2013-08-14
  • pgplot (mcalhoun, open) - x11 since r110730 2013-09-04
  • mpeg2vidcodec (nomaintainer). x11 added in r110736 2013-09-04

Ports where no_x11 may be removed:

  • cairo-devel (ryandesign) - x11 since r78848 2011-05-24
  • darktable (gmail.com:julians37) - x11 since r75631 2011-02-01; no_x11 has never been a compatibility variant
  • giflib (ryandesign) - x11 since r93239 2012-05-17
  • mjpegtools (gmail.com:filippo.natali) - x11 since r87467 2011-11-22

Ports with x11 only/fixed

  • at-spi (nomaintainer) - no_x11 removed in r106775.
  • gedit (devans, open) - no_x11 removed in r106998. - gnuplot (mojca, open) - x11 since r96459 2012-08-10, no_x11 removed in r108795.
  • libsdl (jmr, open) - x11 since r78823 2011-05-23. no_x11 removed in r109316.
  • mlt (dennedy.org:dan) - Probably should be called +gtk2 instead and reversed. no_x11 removed in r110684.
  • openvrml (raphael, open) - x11 since r82212 and r82194 2011-08-10. no_x11 and no_opengl removed in r110726.
  • plplot & plplot-single (takeshi, open) - x11 since r99946 2012-11-21, no_x11 removed in r108600.
  • texlive-bin (dports) - x11 since r82097 2011-08-07, no_x11 removed in r108863.
  • transcode (cogweb.net:lionteeth, devans)

Change History (25)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

at-spi: r106775

comment:2 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 in reply to:  description Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to macsforever2000@…:

Some ports have no_x11 as a legacy variant, but I don't see a reason to keep them around since they do nothing.

The no_x11 legacy variants exist so that users who had previously selected those variants will continue to have X11 disabled after upgrading. All ports that are converted from no_x11 to x11 variants should maintain such a no_x11 legacy variant for one year so that users upgrading the ports do not suddenly receive features they specifically requested not to receive.

comment:4 Changed 11 years ago by mojca (Mojca Miklavec)

While I'm ready to patch at any time - what about the rule that "updates are supposed to run smoothly for a year after the change"?

Gnuplot introduced the option +x11 in August 2012 (r96459). If there is anyone who installed gnuplot with +no_x11 back in July 2012, the update won't go as expected.

While this is hardly a problem for gnuplot (it's been 10 months now which is almost a year): aren't there going to be problems in other packages if an option is simply removed without any grace period?

PS: I'm sorry. I only noticed now that Ryan actually said the same thing. I didn't see his post earlier.

Last edited 11 years ago by mojca (Mojca Miklavec) (previous) (diff)

comment:5 Changed 11 years ago by mojca (Mojca Miklavec)

Here's a grouped list created out of the list above. I didn't check if any other ports contain [no_]x11, I didn't check ports for which it says "remove legacy no_x11", but I checked if any port added +x11 recently.

If anyone wants or agrees with the list, it can be moved to the top description and updates as work proceeds, I didn't dare to do that.

Ports without x11 variant:

Ports with no maintainer:

  • libmpeg2 (nomaintainer) (also no_sdl)
  • mpeg2vidcodec (nomaintainer)
  • nessus-core (nomaintainer) - the difference between gtk and x11 not clear, dependencies are broken (#38114)

Ports with open maintainer:

  • efte (reiffert, open)
  • ghostscript (takanori, open)
  • gstreamer1-gst-plugins-bad (rmstonecipher, open)
  • gstreamer1-gst-plugins-base (rmstonecipher, open) (also no_gnome_vfs, no_ogg)
  • gstreamer010-gst-plugins-bad (rmstonecipher, open)
  • gstreamer010-gst-plugins-base (rmstonecipher, open) (also no_gnome_vfs, no_ogg)
  • kmymoney4 (mk, pixilla, open) (also no_gtk)
  • kmymoney4-devel (mk, pixilla, open) (also no_gtk)
  • pgplot (mcalhoun, open) (#39818)
  • pTeX (takanori, open) (also has no_hiragino, no_otf, no_x11)
  • surf (gmail.com:shreevatsa.public, open)

Other ports:

  • basiliskii-devel (vercruesse.de:opendarwin.nospam)
  • gajim-devel (rene)
  • gnokii (ieee.org:mpal1+bugzilla)
  • gtk2hs (gwright)
  • mlt (dennedy.org:dan) - Probably should be called +gtk2 instead and reversed
  • pidgin (otherware.org:nefar)
  • sheepshaver (vercruesse.de:opendarwin.nospam)
  • wireshark (darkart.com:opendarwin.org) (compare with wireshark-devel, also has no_adns, no_geoip, no_gnutls, no_ipv6, no_libgcrypt, no_libsmi, no_lua, no_rtp, no_ssl, no_x11)

Ports with both x11 and no_x11 by date:

  • graphviz & graphviz-devel (ryandesign) - x11 since r102579 2013-02-04
  • gtk2 (nomaintainer) - x11 changes since r103155 2013-02-16, variant existed earlier
  • gtk3 (cal, open) - x11 changes since r103160 2013-02-16, variant existed earlier
  • ImageMagick (ryandesign) - x11 since r106049 2013-05-13
  • libunique (devans, open) - x11 since r107051 2013-06-16
  • gnome-sharp2 (nomaintainer) - x11 since r107104 2013-06-18
  • libgnomekbd (devans, open) - x11 since r107083 2013-06-17
  • libbonoboui (nomaintainer) - x11 since r107293 2013-06-25
  • libgnomeui (nomaintainer) - x11 since r107294 2013-06-25
  • gromacs & gromacs-double (nomaintainer) - x11 since r108345 2013-07-20
  • gwyddion (rowue, gwyddion.net:yeti) - +quartz since r108367 2013-07-21
  • openssh (nomaintainer) - +xauth since r108465 2013-07-23
  • gd2 (ryandesign) - (version 2.1 will have x11)

Ports where no_x11 may be removed:

  • cairo-devel (ryandesign) - x11 since r78848 2011-05-24
  • darktable (gmail.com:julians37) - x11 since r75631 2011-02-01; no_x11 has never been a compatibility variant
  • giflib (ryandesign) - x11 since r93239 2012-05-17
  • libsdl (jmr, open) - x11 since r78823 2011-05-23
  • mjpegtools (gmail.com:filippo.natali) - x11 since r87467 2011-11-22
  • openvrml (raphael, open) - x11 since r82212 and r82194 2011-08-10

Ports with x11 only/fixed

  • at-spi (nomaintainer) - no_x11 removed in r106775.
  • gedit (devans, open) - no_x11 removed in r106998. - gnuplot (mojca, open) - x11 since r96459 2012-08-10, no_x11 removed in r108795.
  • plplot & plplot-single (takeshi, open) - x11 since r99946 2012-11-21, no_x11 removed in r108600.
  • texlive-bin (dports) - x11 since r82097 2011-08-07, no_x11 removed in r108863.
  • transcode (cogweb.net:lionteeth, devans)
Last edited 11 years ago by mojca (Mojca Miklavec) (previous) (diff)

comment:6 Changed 11 years ago by neverpanic (Clemens Lang)

openssh in r108465.

comment:7 in reply to:  6 Changed 11 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)

comment:8 Changed 11 years ago by mirimiri66@…

Cc: mirimiri66@… added

Cc Me!

comment:9 Changed 11 years ago by mirimiri66@…

Regarding openssh; Now that no_x11 has been removed, how can xorg components be prevented from installing?

port -y upgrade openssh -xauth doesn't seem to work.

comment:10 in reply to:  9 ; Changed 11 years ago by neverpanic (Clemens Lang)

Replying to mirimiri66@…:

port -y upgrade openssh -xauth doesn't seem to work.

Try port upgrade --enforce-variants openssh -xauth. I should probably have added --without-xauth to make sure, though.

comment:11 Changed 11 years ago by tenomoto (Takeshi Enomoto)

plplot in r108600.

comment:12 Changed 11 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)

comment:13 in reply to:  10 ; Changed 11 years ago by mirimiri66@…

Replying to cal@…:

Replying to mirimiri66@…:

port -y upgrade openssh -xauth doesn't seem to work.

Try port upgrade --enforce-variants openssh -xauth. I should probably have added --without-xauth to make sure, though.

It still pulls in xorg components.

comment:14 in reply to:  13 Changed 11 years ago by neverpanic (Clemens Lang)

Replying to mirimiri66@…:

It still pulls in xorg components.

Please file a separate bug for this an cc me, if it still persists. Attach the main.log and explain how it "pulls in xorg components". I cannot reproduce and the dependency list of openssh -xauth (port rdeps openssh -xauth) seems to correctly reflect the variant.

comment:15 Changed 11 years ago by mojca (Mojca Miklavec)

Description: modified (diff)
Port: at-spi gedit gnuplot plplot plplot-single transcode removed

comment:16 Changed 11 years ago by drkp (Dan Ports)

Removed the compatibility variant from texlive-bin in r108863.

comment:17 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:18 Changed 11 years ago by mojca (Mojca Miklavec)

Description: modified (diff)
Port: texlive-bin removed

comment:19 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

Removed from libsdl in r109316 by jmr.

comment:20 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

comment:21 Changed 11 years ago by mf2k (Frank Schima)

Cc: opendarwin.nospam@… removed
Description: modified (diff)

Per email, basiliskii-devel and sheepshaver are no longer being maintained by vercruesse.de:opendarwin.nospam.

comment:22 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

cal removed no_x11 from mlt in r110684.

comment:23 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

no_x11 and no_opengl removed from openvrml in r110726.

comment:24 Changed 11 years ago by mojca (Mojca Miklavec)

Description: modified (diff)

Recently added x11:

  • gd2 (ryandesign) - x11 since r109413 2013-08-14
  • pgplot (mcalhoun, open) - x11 since r110730 2013-09-04

comment:25 Changed 11 years ago by mf2k (Frank Schima)

Description: modified (diff)

added x11 to mpeg2vidcodec in r110736.

Note: See TracTickets for help on using tickets.