Opened 11 years ago

Last modified 15 months ago

#39424 new enhancement

Ports that use qmake: consider using the new qmake portgroup — at Version 13

Reported by: cooljeanius (Eric Gallager) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: portgroup Cc: blair@…, cal@…, css@…, ctreleaven@…, dports@…, easieste@…, ecronin@…, macports@…, macsforever2000@…, mcalhoun@…, michaelld@…, mk@…, mnick@…, nicos@…, ocroquette@…, phw@…, pixilla@…, rowue@…, rudloff@…, ryandesign@…, sami.laine@…, sharky@…, snc@…
Port: arora clustalx GLC_lib goldendict k3dsurf kdiff3 OpenCSG openscad psi-otr qgit QMK-Groundstation qt-assistant qt4-creator-mac qtc-qtsharp qtpfsgui qtscriptgenerator qtsharp QupZilla qwt qxmpp sqlitedbrowser tea tiled

Description (last modified by larryv (Lawrence Velázquez))

(Made as a separate ticket per comment:ticket:38280:22) There is now a qmake portgroup as of r106912. Here is a list of ports that use qmake somewhere in their respective portfiles:

[moved to attachment:qmake_search.txt because it’s pointless and makes ticket modification emails enormous. —larryv]

That list, with just the ports, and the irrelevant ones removed, becomes:

  • abtransfers [r106975, see comment:4 and r107026, see comment:12]
  • arora
  • bitcoin
  • bitdht
  • clustalx
  • cmake
  • djview [no benefit, see comment:10]
  • doxygen
  • GLC_lib
  • gnuradio
  • goldendict
  • gwenhywfar4 [no benefit, see comment:5]
  • k3dsurf
  • kdiff3
  • libQGLViewer [r107011, see comment:11]
  • mythtv-core.25 [no benefit, see comment:7]
  • OpenCSG
  • openscad
  • psi-otr
  • py-pyqt4
  • py26-pyqt3
  • qca
  • qfsm
  • qgit
  • QMK-Groundstation
  • qscintilla
  • qt-assistant
  • qt4-creator-mac
  • qt4-mac-mysql55-plugin
  • qt4-mac-postgresql91-plugin
  • qt4-mac-sqlite2-plugin
  • qtc-qtsharp
  • qtiplot [r106995, see comment:10]
  • qtpfsgui
  • qtscriptgenerator
  • qtsharp
  • QupZilla
  • qwt
  • qwtplot3d
  • qxmpp
  • sqlitedbrowser
  • tea
  • texstudio
  • tiled
  • Vidalia
  • x2goclient
  • xxdiff

Maintainers of these ports, consider whether you could use the qmake portgroup for your respective ports.

Change History (14)

comment:1 Changed 11 years ago by ctreleaven (Craig Treleaven)

I've browsed the linked tickets, but I didn't notice a reason that this is a separate port group. Why not just add these bits to the qt4 port group (maybe version 2.0)?

Also, I noticed the line:

    configure.pre_args-delete       --prefix=${prefix}

I'm pretty sure mythtv-core.25 needs that argument. Is it harmful to other ports?

comment:2 in reply to:  1 Changed 11 years ago by cooljeanius (Eric Gallager)

Replying to ctreleaven@…:

I've browsed the linked tickets, but I didn't notice a reason that this is a separate port group. Why not just add these bits to the qt4 port group (maybe version 2.0)?

I wanted to just include this in the qt4 portgroup, too, but apparently not all ports that use the qt4 portgroup use qmake, so that's why there's now a separate qmake portgroup. See comment:ticket:38272:1 for reference.

Last edited 11 years ago by cooljeanius (Eric Gallager) (previous) (diff)

comment:3 Changed 11 years ago by NicosPavlov

The portgroup is not meant for all ports using qmake. For example, several ports use qmake within standard autotools, thus compiling by

configure
make

These ports are not concerned by this portgroup, as they define variables during the configuration phase. However, several other ports must be compiled through

qmake
make

The portgroup aims at setting variables for these ports.

Typically, in case the configuration phase is made with qmake, the --prefix argument is not used, and PREFIX is, hence the changes of variables in the portgroup. Due to these differences, it did not appear suitable to include these in the qt4 portgroup which is more general for ports depending on qt4.

comment:4 Changed 11 years ago by mkae (Marko Käning)

Done for abtransfers in r106975

comment:5 Changed 11 years ago by mkae (Marko Käning)

I think gwenhywfar4 should be taken out of the above list, since it uses configure!

comment:6 in reply to:  5 Changed 11 years ago by cooljeanius (Eric Gallager)

Replying to mk@…:

I think gwenhywfar4 should be taken out of the above list, since it uses configure!

I'd edit it to do so, except people without commit access can't edit the OP's of tickets (even if they're their own tickets), so I can't (yet)...

comment:7 Changed 11 years ago by ctreleaven (Craig Treleaven)

mythtv-core.25 also uses ./configure and would not benefit from this portgroup.

(And yes, tickets can be assigned to us...but we can't close them or do anything more than comment on them!)

comment:8 Changed 11 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)
Port: gwenhywfar4 mythtv-core.25 removed

Removed gwenhywfar4 and mythtv-core.25.

comment:9 in reply to:  description Changed 11 years ago by larryv (Lawrence Velázquez)

Replying to egall@…:

Here is a list of ports that use qmake somewhere in their respective portfiles:

By the way, please use better judgment in the future when pasting a ton of output from logs or stdout into ticket descriptions or comments. Where by “use better judgment” I mean “don’t do it”.

comment:10 Changed 11 years ago by NicosPavlov

Description: modified (diff)

qtiplot done in r106995.
Suppressing djview as it uses configure.

comment:11 Changed 11 years ago by raphael-st (Raphael Straub)

Cc: raphael@… removed
Description: modified (diff)

libQGLViewer done in r107011.

comment:12 Changed 11 years ago by mkae (Marko Käning)

Description: modified (diff)

modified abtransfers' Portfile in r107026

Changed 11 years ago by larryv (Lawrence Velázquez)

Attachment: qmake_search.txt added

original search output, removed from ticket description

comment:13 Changed 11 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)
Note: See TracTickets for help on using tickets.