webkit-gtk @2.04: build failure with Bison 3.0

[istlota@…]

Every week, I do a sudo port upgrade outdated. This week, it prompted mac ports to be updated from v2.1.3 to 2.2.0, which worked. But, when it attempted to upgrade webkit-gtk from v2.03 to v2.04, that failed with the error contained in the main.log which I will attach.

[istlota@…]

Istlota's webkit-gtk failure main.log

[mielket@…]

Am getting exactly the same error and log output. The root cause seems to be this compilation error logged:

:info:build DerivedSources/ANGLE/glslang_tab.cpp:1785:16: error: no matching function for call to 'yylex'
:info:build       yychar = yylex (&yylval);
:info:build                ^~~~~
:info:build DerivedSources/ANGLE/glslang_tab.cpp:279:12: note: candidate function not viable: requires 2 arguments, but 1 was provided
:info:build extern int yylex(YYSTYPE* yylval_param, void* yyscanner);
:info:build            ^
:info:build 1 error generated.
:info:build make[1]: *** [DerivedSources/ANGLE/libWebCore_la-glslang_tab.lo] Error 1
:info:build make[1]: *** Waiting for unfinished jobs....

[cooljeanius (Eric Gallager)]

This is comment:ticket:39598:109 which I guess should be broken off into a separate ticket...

(There's also #39910 which is related, btw...)

Edit: Wait, you're the same person quoted in that comment... nvm...

[larryv (Lawrence Velázquez)]

Please Cc relevant port maintainers (port info --maintainers) in the future.

[larryv (Lawrence Velázquez)]

Has duplicate #39930.

[tonior@…]

Cc Me!

[jeremyhu (Jeremy Huddleston Sequoia)]

Filed for upstream to resolve ​https://bugs.webkit.org/show_bug.cgi?id=119373

[dbevans (David B. Evans)]

Here's at least part of the problem:

Excerpt from bison 3.0 NEWS file:

** Backward incompatible changes

*** Obsolete features

  '''Support for YYLEX_PARAM and YYPARSE_PARAM is removed''' (deprecated in Bison
  1.875): use %lex-param, %parse-param, or %param.

Grep shows:

webkitgtk-2.0.4 devans$ grep -R YYLEX_PARAM *
DerivedSources/ANGLE/glslang_tab.cpp:#define YYLEX_PARAM context->scanner
Source/ThirdParty/ANGLE/src/compiler/glslang.y:#define YYLEX_PARAM context->scanner
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:#ifdef YYLEX_PARAM
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:# define YYLEX yylex (&yylval, YYLEX_PARAM)

webkitgtk-2.0.4 devans$ grep -R YYPARSE_PARAM *
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:#ifdef YYPARSE_PARAM
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:int yyparse (void *YYPARSE_PARAM);
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:#else /* ! YYPARSE_PARAM */
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:#endif /* ! YYPARSE_PARAM */
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:#ifdef YYPARSE_PARAM
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:yyparse (void *YYPARSE_PARAM)
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:yyparse (YYPARSE_PARAM)
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:    void *YYPARSE_PARAM;
Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp:#else /* ! YYPARSE_PARAM */

This code is from the Google ANGLE Project. Perhaps it would be expedient to revert bison to its pre-3.0 version until this is ironed out upstream.

[larryv (Lawrence Velázquez)]

Replying to devans@…:

Perhaps it would be expedient to revert bison to its pre-3.0 version until this is ironed out upstream.

Or create a bison2 port.

(Tangentially, webkit-gtk doesn’t currently declare a build dependency on bison, but it should.)

[onurdomanic@…]

Cc Me!

[diochnos]

Cc Me!

[c.maglie@…]

Cc Me!

[dbevans (David B. Evans)]

Replying to larryv@…:

(Tangentially, webkit-gtk doesn’t currently declare a build dependency on bison, but it should.)

Explicit dependencies on bison, flex added in r108797. Bison was previously loaded implicitly.

[larryv (Lawrence Velázquez)]

Has duplicate #39955.

[mbrethen]

Cc Me!

[dcecchin@…]

Cc Me!

[cooljeanius (Eric Gallager)]

Replying to larryv@…:

Replying to devans@…:

Perhaps it would be expedient to revert bison to its pre-3.0 version until this is ironed out upstream.

Or create a bison2 port.

That'd be the solution that I would go with.

[larryv (Lawrence Velázquez)]

Has duplicates #39957 and #39960.

[stefan.bollmann@…]

Cc Me!

[andrew.long@…]

Cc Me!

[chief1983@…]

Cc Me!

[robert_snell@…]

Cc Me!

[adamb2903]

Cc Me!

[ci42]

Has duplicate #39964.

[tony.li@…]

Cc Me!

[tony.li@…]

Workaround:

port activate bison@2.7.1_9
port clean webkit-gtk 
port upgrade webkit-gtk

[larryv (Lawrence Velázquez)]

The bison port was rolled back to 2.7.1 in r108830. Clean webkit-gtk, do a selfupdate, and try again.

[jeremyhu (Jeremy Huddleston Sequoia)]

Cc Me!

[istlota@…]

That fixed it. This time, when I did a sudo port upgrade outdated, bison was downgraded from v3.0.0 to v2.7.1, after which harfbuzz-icu upgraded to v0.9.19_2 and webkit-gtk upgraded successfully to v2.0.4_1. Thanks.

[jeremyhu (Jeremy Huddleston Sequoia)]

Fixed upstream. Worked around in MacPorts.

[larryv (Lawrence Velázquez)]

adaptation of upstream fix

[larryv (Lawrence Velázquez)]

I’ve backported upstream’s fix​, and it seems to work fine in my Mountain Lion VM. May I commit it? This is blocking #41600.

[tonior@…]

Cc Me!

[dbevans (David B. Evans)]

Replying to larryv@…:

I’ve backported upstream’s fix​, and it seems to work fine in my Mountain Lion VM. May I commit it? This is blocking #41600.

Ok with me as long as you fix it if it breaks (I don't have a machine to test) :-) .

[larryv (Lawrence Velázquez)]

Replying to devans@…:

Ok with me as long as you fix it if it breaks (I don't have a machine to test) :-) .

Fair enough :P

[larryv (Lawrence Velázquez)]

r133867