Opened 11 years ago
Last modified 11 years ago
#40361 new submission
Avogadrolibs @0.6.0 — at Version 4
Reported by: | c.herbig@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | avogadrolibs |
Description (last modified by mf2k (Frank Schima))
Support libraries for Avogadro2
Need #40359 fixed first.
Change History (7)
Changed 11 years ago by c.herbig@…
comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)
comment:2 follow-up: 3 Changed 11 years ago by mf2k (Frank Schima)
Keywords: | haspatch removed |
---|---|
Version: | 2.2.0 |
Thanks for the contribution. Note that the "haspatch" keyword is redundant for a submission ticket.
A few quick comments:
- Change
depends_lib
todepends_lib-append
since you are using the cmake portgroup and it may overwrite dependencies from it. It may not be necessary in this case, but it is best practice. - There is currently no functioning qt4-x11 port.
Changed 11 years ago by c.herbig@…
Attachment: | Portfile.3 added |
---|
BSD-3-Clause to BSD, remove comments
comment:3 Changed 11 years ago by c.herbig@…
Replying to macsforever2000@…:
Thanks for the contribution. Note that the "haspatch" keyword is redundant for a submission ticket.
A few quick comments:
- Change
depends_lib
todepends_lib-append
since you are using the cmake portgroup and it may overwrite dependencies from it. It may not be necessary in this case, but it is best practice.- There is currently no functioning qt4-x11 port.
A qt4-x11 port is currently available in the public macports distribution; it is currently of 'nomaintainer' status. If this is problematic, the port should be removed or a note should be appended that it is known to be broken...
comment:4 Changed 11 years ago by mf2k (Frank Schima)
Description: | modified (diff) |
---|
Note: See
TracTickets for help on using
tickets.
Looking at the dependencies, I take it this depends on #40359 being committed first