hping3 @20051105_1: build fails: expected parameter declarator

[rr@…]

sytrymb:~ root# port install hping3
--->  Computing dependencies for hping3
--->  Fetching archive for hping3
--->  Attempting to fetch hping3-20051105_1.darwin_13.x86_64.tbz2 from http://lil.fr.packages.macports.org/hping3
--->  Attempting to fetch hping3-20051105_1.darwin_13.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/hping3
--->  Attempting to fetch hping3-20051105_1.darwin_13.x86_64.tbz2 from http://packages.macports.org/hping3
--->  Fetching distfiles for hping3
--->  Attempting to fetch hping3-20051105.tar.gz from http://lil.fr.distfiles.macports.org/hping3
--->  Verifying checksums for hping3
--->  Extracting hping3
--->  Applying patches to hping3
--->  Configuring hping3
--->  Building hping3
Error: org.macports.build for port hping3 returned: command execution failed
Please see the log file for port hping3 for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_hping3/hping3/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port hping3 failed

:info:build make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_hping3/hping3/work/hping3-20051105'
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  main.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  getifname.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  getlhs.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  parseoptions.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  datafiller.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  datahandler.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  gethostname.c
:info:build gcc -c -O2 -Wall   -DUSE_TCL -g  binding.c
:info:build gethostname.c:21:8: error: expected parameter declarator
:info:build size_t strlcpy(char *dst, const char *src, size_t siz);
:info:build        ^

[tryn@…]

I ran into this with Homebrew, and it has to do with the new/default secure strlcpy/strlcat functions.

One option is to dive into the source and make it properly secure. Considering it hasn't been updated for eight years, I went with the second options.

Append this to the CFLAGS: "-D_FORTIFY_SOURCE=0".

[sck-nogas (Scott C. Kennedy)]

Replying to tryn@…:

I ran into this with Homebrew, and it has to do with the new/default secure strlcpy/strlcat functions.

One option is to dive into the source and make it properly secure. Considering it hasn't been updated for eight years, I went with the second options.

Append this to the CFLAGS: "-D_FORTIFY_SOURCE=0".

Did the same, it worked for me.

[kvanrhee@…]

Replying to tryn@…:

I ran into this with Homebrew, and it has to do with the new/default secure strlcpy/strlcat functions.

One option is to dive into the source and make it properly secure. Considering it hasn't been updated for eight years, I went with the second options.

Append this to the CFLAGS: "-D_FORTIFY_SOURCE=0".

Can you explain how I do this? Or give me hint to the right direction so I can figure it out myself? Thanks!

[Schamschula (Marius Schamschula)]

Cc Me!

[kvanrhee@…]

Cc Me!

[schnide (Joe Schnide)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #41336.

[meg_lao@…]

Replying to kvanrhee@…:

Replying to tryn@…:

I ran into this with Homebrew, and it has to do with the new/default secure strlcpy/strlcat functions.

One option is to dive into the source and make it properly secure. Considering it hasn't been updated for eight years, I went with the second options.

Append this to the CFLAGS: "-D_FORTIFY_SOURCE=0".

Can you explain how I do this? Or give me hint to the right direction so I can figure it out myself? Thanks!

I edited the file /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_net_hping3/hping3/work/Makefile and change line

CCOPT= -O2 -Wall -DUSE_TCL

to

CCOPT= -O2 -Wall -DUSE_TCL -D_FORTIFY_SOURCE=0

That works for me.

[vincent.passaro@…]

Is there a fix in the works for this ticket?

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #42417.

[SickTeddyBear]

Cc Me!

[macports@…]

Replying to meg_lao@…:

Replying to kvanrhee@…:

Replying to tryn@…:

I ran into this with Homebrew, and it has to do with the new/default secure strlcpy/strlcat functions.

One option is to dive into the source and make it properly secure. Considering it hasn't been updated for eight years, I went with the second options.

Append this to the CFLAGS: "-D_FORTIFY_SOURCE=0".

Can you explain how I do this? Or give me hint to the right direction so I can figure it out myself? Thanks!

I edited the file /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_net_hping3/hping3/work/Makefile and change line

 CCOPT= -O2 -Wall   -DUSE_TCL

to

 CCOPT= -O2 -Wall   -DUSE_TCL -D_FORTIFY_SOURCE=0

That works for me.

Could you please provide any hint as to how to proceed with the installation of hping3? The Makefile mentioned in your post does not exist after a (failed) build on my system. So I'd like to know how to apply the fix and proceed with the installation thereafter. Thanks in advance!

[macports@…]

Cc Me!

[Schamschula (Marius Schamschula)]

I revisited hping3 this morning: I've updated the Portfile (no change, but moved livecheck to bottom), and added -D_FORTIFY_SOURCE=0 to patch-Makefile.in.diff. Both are attached.

[macports@…]

Replying to mschamschula@…:

I revisited hping3 this morning: I've updated the Portfile (no change, but moved livecheck to bottom), and added -D_FORTIFY_SOURCE=0 to patch-Makefile.in.diff. Both are attached.

When are the patched files expected to be available in the MacPorts SVN?

[jul_bsd@…]

here a better way without disabling security function (which kind of boo for a security tool), just enclose strlcpy as Mavericks as it (same bug than for snort #42531)

also:

• add mode line
• reverse the no_tcl (similar to no_x11 #39383)
• compiler issue (#41347)
• universal variant

[mf2k (Frank Schima)]

Assigning to new maintainer.

[jmroot (Joshua Root)]

Appears to have been committed in r120992, r120993. (Not sure why a second ticket was opened.)