hugin-app fails to compile

[davehun (David Hunninsett)]

Hugin-app fails to build on a clean mavericks install

port -v
MacPorts 2.2.1

snip from log

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/zthread/src/ThreadQueue.cxx:146:7: warning: add explicit braces to avoid dangling else [-Wdangling-else]
:info:build       else
:info:build       ^
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/zthread/src/ThreadOps.cxx:52:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/zthread/src/posix/ThreadOps.cxx:106:13: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
:info:build   if(result = (pthread_getschedparam(impl->_tid, &policy, &param) == 0)) {
:info:build      ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/zthread/src/posix/ThreadOps.cxx:106:13: note: place parentheses around the assignment to silence this warning
:info:build   if(result = (pthread_getschedparam(impl->_tid, &policy, &param) == 0)) {
:info:build             ^
:info:build      (                                                                 )
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/zthread/src/posix/ThreadOps.cxx:106:13: note: use '==' to turn this assignment into an equality comparison
:info:build   if(result = (pthread_getschedparam(impl->_tid, &policy, &param) == 0)) {
:info:build             ^
:info:build             ==
:info:build 1 warning generated.
:info:build 1 warning generated.
:info:build Linking CXX static library libZThread.a

[ryandesign (Ryan Carsten Schmidt)]

I recently spent some time resolving the issues building hugin-app. It builds fine for me on Mavericks.

The portion of the log you quoted above does not show any error; it only shows warnings and notes. The actual error is:

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx:275:18: error: out-of-line definition of 'ImageExportInfo' does not match any declaration in 'vigra::ImageExportInfo'
:info:build ImageExportInfo::ImageExportInfo( const char * filename )
:info:build                  ^~~~~~~~~~~~~~~
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx:443:18: error: out-of-line definition of 'ImageImportInfo' does not match any declaration in 'vigra::ImageImportInfo'
:info:build ImageImportInfo::ImageImportInfo( const char * filename )
:info:build                  ^~~~~~~~~~~~~~~
:info:build 2 errors generated.

I've seen some "out-of-line definition" errors in other tickets but I'm not seeing them with this port. Please indicate your version of Xcode and clang; maybe they're different from mine.

[thamster20@…]

I have the same issue on mavericks.

I was trying to build +universal though.

> clang --version
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
Target: x86_64-apple-darwin13.0.0
Thread model: posix

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex && /usr/bin/clang  -DHUGIN_HSI -Dhuginvigraimpex_EXPORTS -pipe -Os -I/opt/local/include -arch x86_64 -arch i386  -DNDEBUG -arch x86_64 -arch i386 -fPIC -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/hugin_base -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/celeste -I/opt/local/include -I/opt/local/include/OpenEXR -F//System/Library/Frameworks -I/System/Library/Frameworks/GLUT.framework/Versions/A/Headers -I/opt/local/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7    -o CMakeFiles/huginvigraimpex.dir/rgbe.c.o   -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/rgbe.c
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx:275:18: error: 
      out-of-line definition of 'ImageExportInfo' does not match any declaration in 'vigra::ImageExportInfo'
ImageExportInfo::ImageExportInfo( const char * filename )
                 ^~~~~~~~~~~~~~~
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx:443:18: error: 
      out-of-line definition of 'ImageImportInfo' does not match any declaration in 'vigra::ImageImportInfo'
ImageImportInfo::ImageImportInfo( const char * filename )
                 ^~~~~~~~~~~~~~~
2 errors generated.
make[2]: *** [src/foreign/vigra/vigra_impex/CMakeFiles/huginvigraimpex.dir/imageinfo.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0'

[macports@…]

I'm getting the same error on Mavericks, haven't specified any variants on hugin-app installation

% clang --version     
Apple LLVM version 5.0 (clang-500.2.79) (based on LLVM 3.3svn)
Target: x86_64-apple-darwin13.0.2
Thread model: posix

Xcode 5.0.2
MacPorts 2.2.1
Mac OS X 10.9.1

[  5%] Building CXX object src/foreign/vigra/vigra_impex/CMakeFiles/huginvigraimpex.dir/imageinfo.cxx.o
cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex && /usr/bin/clang++   -DHUGIN_HSI -Dhuginvigraimpex_EXPORTS -pipe -Os -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=0 -ftemplate-depth-1024 -I/opt/local/include -arch x86_64  -DNDEBUG -arch x86_64 -fPIC -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/hugin_base -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/celeste -I/opt/local/include -I/opt/local/include/OpenEXR -F//System/Library/Frameworks -I/System/Library/Frameworks/GLUT.framework/Versions/A/Headers -I/opt/local/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7    -o CMakeFiles/huginvigraimpex.dir/imageinfo.cxx.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx:275:18: error: out-of-line definition of
      'ImageExportInfo' does not match any declaration in 'vigra::ImageExportInfo'
ImageExportInfo::ImageExportInfo( const char * filename )
                 ^~~~~~~~~~~~~~~
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx:443:18: error: out-of-line definition of
      'ImageImportInfo' does not match any declaration in 'vigra::ImageImportInfo'
ImageImportInfo::ImageImportInfo( const char * filename )
                 ^~~~~~~~~~~~~~~
2 errors generated.

[macports@…]

Had a look at the file/line referenced by the error:

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_hugin-app/hugin-app/work/hugin-2013.0.0/src/foreign/vigra/vigra_impex/imageinfo.cxx

For whatever reason it's a modified file from the vigra library (which is also a dependency) but it's based on v1.4 while vigra in macports is now up to v1.10 (as of ~5 weeks ago). So am wondering if perhaps the changes to the vigra API since 1.4 are perhaps related to this?

[ryandesign (Ryan Carsten Schmidt)]

Ok, this seems to be another instance where the patch from #40656 (which I'm using) fixes a problem. Committed a local version of the fix in r115211.

[macports@…]

thanks, can confirm the patch has fixed the issue for me, hugin-app builds fine now