Changes between Initial Version and Version 1 of Ticket #42344, comment 6


Ignore:
Timestamp:
Jan 23, 2024, 4:20:40 AM (8 months ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42344, comment 6

    initial v1  
    33In this comment https://github.com/sjorek/macports-php/issues/2#issuecomment-1544344271 I collected my (selfish) arguments, why I'm still struggling with the idea of submitting this port-definitions to the MacPorts-base. To save you some time, I'll quote them here:
    44
    5 ----
    6 
    7 … one must consider the tight integration of my composer-ports with the historically evolved bash-completion (variant)(https://github.com/sjorek/macports-php/blob/master/php/composer1/Portfile#L204-L222), which in turn is provided as separate port(https://github.com/sjorek/macports-php/blob/master/sysutils/composer-bash-completion/Portfile) here and implemented in https://github.com/sjorek/composer-bash-completion.
    8 
    9 The difficulty I see (at least for me) is that _I don't want to loose the features of this bash-completion implementation_. I'm aware of the “new” builtin (symfony-driven) bash-completion support in composer itself: https://getcomposer.org/doc/03-cli.md#bash-completions And I invested some time to enhance parts of the new bash completion (https://github.com/composer/composer/issues/11131), but still the new bash-completion lacks features from my implementation (which I really use a lot). To make it short - a shift of the (plain) composer-port to the macports-base would be much easier (for me), if composer's builtin bash-completion would be a little bit more sophisticated, because then I could get rid of my implementation, and I would only have to transfer the plain composer-Ports to macports and use its builtin bash-completion only.
    10 
    11 See how selfish I am? 😄
    12 
    13 
    14 ----
     5> … one must consider the tight integration of my composer-ports with the historically evolved [https://github.com/sjorek/macports-php/blob/master/php/composer1/Portfile#L204-L222 bash-completion (variant)], which in turn is provided [https://github.com/sjorek/macports-php/blob/master/sysutils/composer-bash-completion/Portfile as separate port] here and implemented in https://github.com/sjorek/composer-bash-completion.
     6>
     7> The difficulty I see (at least for me) is that ''I don't want to loose the features of this bash-completion implementation''. I'm aware of the “new” builtin (symfony-driven) bash-completion support in composer itself: https://getcomposer.org/doc/03-cli.md#bash-completions And I invested some time to [https://github.com/composer/composer/issues/11131 enhance parts of the new bash completion], but still the new bash-completion lacks features from my implementation (which I really use a lot). To make it short - a shift of the (plain) composer-port to the macports-base would be much easier (for me), if composer's builtin bash-completion would be a little bit more sophisticated, because then I could get rid of my implementation, and I would only have to transfer the plain composer-Ports to macports and use its builtin bash-completion only.
     8>
     9> See how selfish I am? 😄
    1510
    1611This bothers me since quite a lot of time (years) and has nothing to do with my will to contribute (and even maintain) the composer port-definition.