Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#42456 closed update (fixed)

ROOT : Update to 5.34.15

Reported by: cjones051073 (Chris Jones) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: mattiafrancescomoro@…
Port: root

Description

Bump ROOT to 5.34.15

Upstream has also switch the default GUI to a native Cocoa version for OSX 10.8 and newer, so to stay consist this patch does the same. The Cocoa backend seems much more stable now in my tests, and also works when ROOT is imported via python (Previously a stumbling block, as it didn't work). So making it the default now seems reasonable...

Chris

Attachments (1)

root.diff (1.3 KB) - added by cjones051073 (Chris Jones) 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by cjones051073 (Chris Jones)

Attachment: root.diff added

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.2.1

r116978. Thanks!

comment:2 Changed 11 years ago by mojca (Mojca Miklavec)

It's a pity that you forgot to include the patch for #41572 when increasing the version.

But why not simply making +cocoa default on all versions of OS X? Yes, I know you argued about consistency, but a while back the argument was that cocoa was misbehaving. I doubt that it now only misbehaves on 10.7 and older?

comment:3 in reply to:  2 Changed 11 years ago by cjones051073 (Chris Jones)

Replying to mojca@…:

It's a pity that you forgot to include the patch for #41572 when increasing the version.

I didn't forget, it was intentional. I only patch things when there is no other option, and in this case there is; Stick with the builtin library. I'll revert once it cleanly builds without the need for any patching.

But why not simply making +cocoa default on all versions of OS X? Yes, I know you argued about consistency, but a while back the argument was that cocoa was misbehaving. I doubt that it now only misbehaves on 10.7 and older?

I prefer not to second guess upstream. ROOT decided to only enable it by default on 10.8 onwards. Presumably there is a reason for this, so I just do the same. It is after all only the default, users are free to change this to whatever they want themselves.

Chris

Last edited 11 years ago by cjones051073 (Chris Jones) (previous) (diff)
Note: See TracTickets for help on using tickets.