libffi: libffi.pc is broken

[jf (Jeffrey 'jf' Lim)]

s/toolexeclibdir=$(libdir)/toolexeclibdir=${libdir}/

This breaks 'pkg-config --libs libffi', and results in failure to link anything with libffi.

[jf (Jeffrey 'jf' Lim)]

Confirmation and patch available at ​https://sourceware.org/ml/libffi-discuss/2014/msg00065.html. The patch is for configure.ac, though, and requires a regeneration of 'configure'. It would be simpler (and really, that's all that's needed) to simply patch 'configure' directly, and then wait for the (soon? hopefully?) new release to be released with the fix upstream.

For now, this patch should do very nicely for macports (I'm only bothering to fix lines that will affect macports, btw, in order to keep the patch shorter):

--- configure.orig	2014-07-29 17:25:49.000000000 +0800
+++ configure	2014-07-29 17:25:36.000000000 +0800
@@ -18789,8 +18789,8 @@
     toolexecdir='$(exec_prefix)/$(target_alias)'
     toolexeclibdir='$(toolexecdir)/lib'
   else
-    toolexecdir='$(libdir)/gcc-lib/$(target_alias)'
-    toolexeclibdir='$(libdir)'
+    toolexecdir='${libdir}/gcc-lib/$(target_alias)'
+    toolexeclibdir='${libdir}'
   fi
   multi_os_directory=`$CC $CFLAGS -print-multi-os-directory`
   case $multi_os_directory in
@@ -18799,7 +18799,7 @@
   esac
 
 else
-  toolexeclibdir='$(libdir)'
+  toolexeclibdir='${libdir}'
 fi

[cooljeanius (Eric Gallager)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Thanks!