mpv: update to 0.6.0

[marek.krolikowski@…]

There is new version of mpv.

I'm attaching the patch. It's tested, mpv builds and works (command line and bundle).

[ryandesign (Ryan Carsten Schmidt)]

Thanks.

The revision should be reset to 0 when the version is increased. You can simply remove the revision line to do this.

Why is the code relating to the bundle variant not located inside the bundle variant declaration? Wouldn't that be clearer?

[marek.krolikowski@…]

It's my first time patching portfile.

1. Reseting revision is no problem
2. This code must be run right after build, I found the "post-build" method. How can I achieve this inside variant declaration?

[Ionic (Mihai Moldovan)]

Hi,

thanks for the reminder. I haven forgotten about mpv and its version bumps, but have been busy with other system updates and university stuff lately.

I'll get working on that tomorrow. There is also another bug I would like to sort out at the same time as updating the package.

Running the script to build a bundle is likely unnecessary, given that the build system already does this, so just moving the completed mpv.app should be good enough. Is there any reason you're trying to change this behavior? I'll take a look to see whether the build system has changed in this regard, but up until 0.5.0 (my current version, though only tested locally and not published in MacPorts due to the mentioned outstanding bug I wanted to fix at the same time as updating) this wasn't the case.

[marek.krolikowski@…]

Running the script copies library dependencies to the bundle (without it only the mpv binary is included). I'm not sure we want or need that. It adds 56MB to the bundle but makes it standalone. I attached list of libraries added to the bundle.

[marek.krolikowski@…]

Libraries included in app bundle

[marek.krolikowski@…]

I created "bundle_standalone" variant which conflicts with bundle variant so there is no overhead by default. Variant "bundle" creates bundle containing only mpv binary, bundle_standalone additionaly contains library dependencies.

Upstream removed some build options so I adjusted the Portfile.

[larryv (Lawrence Velázquez)]

Replying to marek.krolikowski@…:

I created "bundle_standalone" variant which conflicts with bundle variant so there is no overhead by default. Variant "bundle" creates bundle containing only mpv binary, bundle_standalone additionaly contains library dependencies.

Please, no silly variants like this. Providing a standalone bundle looks like it just makes everything more complicated, so don’t bother. We don’t really go out of our way to provide self-contained bundles, so it’s fine for the app to use libraries in the MacPorts prefix.

[Ionic (Mihai Moldovan)]

Basically it not building on SL. #44662

Well, I do not like building a self-contained version, because it creates duplicates of libraries which are not updated when the base package is updated (think ffmpeg) and furthermore makes both the binary in ${prefix}/bin and ${applications_path}/mpv.app behave differently, if system packages change, but mpv is not rebuilt.

Thus I refrained from bundling libraries when crafting the mpv Portfile on purpose.

[marek.krolikowski@…]

It's no problem, just ignore the change then. I'm new to the community and don't know the ways yet.

[Ionic (Mihai Moldovan)]

Update mpv to version 0.6.0.

[Ionic (Mihai Moldovan)]

Maintainer update to 0.6.0.

Needless to say, please commit.

Potential fix for #44662 is independent from that and will be published in the other bug report.

[Ionic (Mihai Moldovan)]

If possible, please apply this after #44662 to see whether the SL build bot finishes successfully.

[neverpanic (Clemens Lang)]

In r126689.