Opened 10 years ago

Closed 10 years ago

#47196 closed defect (fixed)

lparse @1.1.2_0: sundry fixes

Reported by: larryv (Lawrence Velázquez) Owned by: nerdling (Jeremy Lavergne)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: lparse

Description

The attached patches get lparse in working order (and fix #40940 and #41871). May I commit them?

Attachments (6)

0001-lparse-Fix-never-failing-makefile-recipes.patch​ (2.2 KB) - added by larryv (Lawrence Velázquez) 10 years ago.
Fix never-failing makefile recipes
0002-lparse-Use-the-right-compiler.patch​ (743 bytes) - added by larryv (Lawrence Velázquez) 10 years ago.
Use the right compiler
0003-lparse-Fix-detection-of-Bison-version.patch​ (2.7 KB) - added by larryv (Lawrence Velázquez) 10 years ago.
Fix detection of Bison version
0004-lparse-Avoid-namespace-collisions-41871.patch​ (14.0 KB) - added by larryv (Lawrence Velázquez) 10 years ago.
Avoid namespace collisions (fixes #41871)
0005-lparse-Make-configure-respect-CXXFLAGS-and-LDFLAGS.patch​ (2.1 KB) - added by larryv (Lawrence Velázquez) 10 years ago.
Make configure respect CXXFLAGS and LDFLAGS
0006-lparse-Fix-universal-build-40940.patch​ (829 bytes) - added by larryv (Lawrence Velázquez) 10 years ago.
Fix universal build (fixes #40940)

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: 0001-lparse-Fix-never-failing-makefile-recipes.patch​ added

Fix never-failing makefile recipes

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: 0002-lparse-Use-the-right-compiler.patch​ added

Use the right compiler

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: 0003-lparse-Fix-detection-of-Bison-version.patch​ added

Fix detection of Bison version

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: 0004-lparse-Avoid-namespace-collisions-41871.patch​ added

Avoid namespace collisions (fixes #41871)

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: 0005-lparse-Make-configure-respect-CXXFLAGS-and-LDFLAGS.patch​ added

Make configure respect CXXFLAGS and LDFLAGS

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: 0006-lparse-Fix-universal-build-40940.patch​ added

Fix universal build (fixes #40940)

comment:1 Changed 10 years ago by nerdling (Jeremy Lavergne)

Looks good; you'll update the other tickets too?

comment:2 Changed 10 years ago by nerdling (Jeremy Lavergne)

One question regarding patch 5: is O3 really the default?

Version 0, edited 10 years ago by nerdling (Jeremy Lavergne) (next)

comment:3 in reply to:  1 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to snc@…:

Looks good; you'll update the other tickets too?

Yeah, I’ll take care of them.

comment:4 in reply to:  2 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to snc@…:

D'ooh, just saw it. For patch 5: O3 was previously forced by ./configure.

Right; I was just maintaining the current behavior. I don’t feel particularly strongly about it, but it’s nice to let the portfile dictate the optimization level.

comment:5 Changed 10 years ago by larryv (Lawrence Velázquez)

Resolution: → fixed
Status: new → closed

r134117:134122

Note: See TracTickets for help on using tickets.