Opened 9 years ago
Closed 9 years ago
#48405 closed update (fixed)
webtoolkit-java-sdk @2.7.0
| Reported by: | roger.filmyer@… | Owned by: | nhojpatrick (John Patrick) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.3 |
| Keywords: | Cc: | Ionic (Mihai Moldovan) | |
| Port: | webtoolkit-java-sdk |
Description
GWT's newest version is 2.7.0. A few things have changed between 2.4.0 and now, and the website and file location has changed.
I've created an updated portfile (with huge thanks to Ionic on the IRC channel)
Note that this does the same thing that the original port does - there's a source version available on github, but this just downloads the compiled files from google.
Attachments (2)
Change History (11)
Changed 9 years ago by roger.filmyer@…
comment:1 Changed 9 years ago by Ionic (Mihai Moldovan)
| Cc: | ionic@… added; nhoj.patrick@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to nhoj.patrick@… |
comment:2 Changed 9 years ago by Ionic (Mihai Moldovan)
Please attach a diff against the current Portfile. This helps evaluation the changes.
Changed 9 years ago by roger.filmyer@…
| Attachment: | Portfile.diff added |
|---|
Diff of my changes to the portfile.
comment:3 Changed 9 years ago by roger.filmyer@…
Ionic asked a question on the IRC channel asking why the NOTES were taken out.
According to the documentation as of 2.7, the environment variable changes are no longer necessary. WEBTOOLKIT_HOME is not used anymore, and the changes to PATH are recommended, but not necessary.
comment:4 Changed 9 years ago by Ionic (Mihai Moldovan)
I agree. Looks like WEBTOOLKIT_HOME was mentioned in the original Portfile 4 years ago (#32849), but a web search doesn't bring up anything substantial.
Diff looks good to me. Let's hope the maintainer responds (otherwise, it's timeout time and I'll commit it myself...)
comment:5 Changed 9 years ago by nhojpatrick (John Patrick)
Roger if you wish to become the maintainer, please add yourself and remove myself, or simply remove myself so it becomes openmaintainer.
Diff looks okay but I no longer work with GWT so unable to confirm if it results in a functioning port.
Everything I now work with is rest micro-services mostly using angularjs, so not used GWT for at last 12 months.
ionic, i'm happy if that diff is include and also if I'm removed as a maintainer.
comment:6 Changed 9 years ago by Ionic (Mihai Moldovan)
Technically speaking, if the last maintainer is unassigned, the port becomes "nomaintainer". openmaintainer can only go with at least one maintainer and means that the maintainer doesn't mind small changes to be carried out by others.
I'll apply, but we should clear up that situation beforehand. Since you seem to have no plans on maintaining that port any longer (which I can understand), we should either make it nomaintainer or have someone else step in.
comment:8 Changed 9 years ago by roger.filmyer@…
So I think nomaintainer would be better than openmaintainer. Ultimately, I wanted to update this port as a means to an end in getting 39197 resolved. I don't have an immediate intention of using this right now.
This seems like a port that isn't often updated, and if it is, it doesn't look like there's a lot that depends on it. So I imagine that there isn't much pressure for it to be *actively* maintained currently. So I guess nomaintainer wouldn't have a big downside.
comment:9 Changed 9 years ago by Ionic (Mihai Moldovan)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed your patch in r139044 with one change: maintainer removed, nomaintainer added.
Updated portfile