Opened 9 years ago
Last modified 9 years ago
#49821 closed update
libsndfile - update to 1.0.26 — at Version 2
| Reported by: | janstary (Jan Starý) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.4 |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | libsndfile |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
Here is a patch to the Portfile of audio/libsndfile
which brings it to the latest 1.0.26 release,
and the upgraded version of files/
The speex.patch removes SPEEX_* from EXTERNAL_* in configure;
I believe speex.patch is a better name, and configure.patch
should be replaced with this.
The carbon.patch is a better version of fix-include.patch
which it should replace. Not only does it remove the Carbon.h include
from sndfile-play.c, but it removes Carbon altogether.
I am leaving src__config.h.ed as is, but I am not completely sure
about its purpose; if __BIG_ENDIAN__, __LP64__, etc, is defined,
then ./configure (which creates config.h) is supposed to figure out
the SIZEOF_LONG etc, right? If not, it's a bug in configure,
not something we should patch in the resulting config.h, right?
I also removed the sqlite variant from the Portfile. Only sndfile-regtest uses sqlite; does anybody use sndfile-regtest?
Jan
Change History (4)
Changed 9 years ago by janstary (Jan Starý)
| Attachment: | carbon.patch added |
|---|
Changed 9 years ago by janstary (Jan Starý)
| Attachment: | speex.patch added |
|---|
remove SPEEX_* from libsndfile
comment:1 follow-up: 2 Changed 9 years ago by janstary (Jan Starý)
(The double underscore fucked up my message.)
comment:2 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
| Description: | modified (diff) |
|---|
Replying to hans@…:
(The double underscore fucked up my message.)
I fixed your formatting. Remember to use WikiFormatting and to preview before submitting.
I am leaving
src__config.h.edas is, but I am not completely sure about its purpose; if__BIG_ENDIAN__,__LP64__, etc, is defined, then ./configure (which creates config.h) is supposed to figure out theSIZEOF_LONGetc, right? If not, it's a bug in configure, not something we should patch in the resulting config.h, right?
You can easily discover using "svn log" and "svn blame" that this file was added in r42762 to resolve #17088, when libsndfile was at version 1.0.17. I cannot tell you whether it is still needed today at version 1.0.26 but you could certainly test and find out whether the problem described in #17088 returns if you remove it. If it does, then you should not remove the patch. If this ed script fixes the problem, I'm not concerned about whether there are other ways that the problem could have been fixed. Using ed scripts to fix this type of problem has precedent in MacPorts; see the glib2 port for example.
remove Carbon from libsndfile