Changes between Initial Version and Version 1 of Ticket #51619, comment 30


Ignore:
Timestamp:
Jan 1, 2017, 1:27:10 AM (8 years ago)
Author:
RJVB (René Bertin)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51619, comment 30

    initial v1  
    66
    77{{{
    8 if {[something]} {
     8if {[port:qt5_is_installed]} {
    99    PortGroup qt5 1.0
    1010    return
     11}
     12}}}
     13
     14and in `qt5-1.0.tcl`
     15
     16{{{
     17if {[port:qt5_is_installed] || [variant_isset qt5kde]} {
     18    if {[port_opts_out]} {
     19        return -code error "Incompatible qt5-kde port installed"
     20    } else {
     21        PortGroup qt5 1.0
     22        return
     23    }
    1124}
    1225}}}
    … …  
    1730The appeal is that we will each have more leeway in the choice of the exact implementation like for instance `qt5.depends_component` which means it wouldn't have to implement "adaptive depspecs".
    1831
    19 The crucial condition here is of course that we must both agree to transfer control to the other PG when that is dictated by the installed Qt5 port or user preference indicated in some other way. I have no problem with that (it's what I'm aiming at already) but I would have preferred to shoulder that responsibility (through a shared PG) and not burden others with it because unhappy changes could cause considerable breakage in KF5 functionality.
     32The crucial condition here is of course that we must both agree to transfer control to the other PG when that is dictated by the installed Qt5 port or user preference indicated in some other way.I have no problem with that (it's what I'm aiming at already) but I would have preferred to shoulder that responsibility (through a shared PG) and not burden others with it because unhappy changes could cause considerable breakage in KF5 functionality.
     33It will probably be necessary too to protect the PGs against loading them multiple times to avoid unexpected situations where for some reason the 2 PGs are loaded in succession.
    2034
    2135We might do something similar for the qmake5 PG too.