Changes between Initial Version and Version 1 of Ticket #52446
- Timestamp:
- Sep 29, 2016, 8:00:15 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #52446
-
Property
Priority
changed from
Normal
toHigh
-
Property
Priority
changed from
-
Ticket #52446 – Description
initial v1 1 1 Each buildbot failure email is sent not only to the maintainers of the ports affected by this build failure, but also to the recipients of all previous build failure emails. 2 2 3 I've looked at [browser:contrib/buildbot-test/master.cfg the code] for a long time and don't understand it. Obviously the list of interested users isn't being cleared at the beginning of each build. But I don't see where in the code anything gets added to the list of interested users. I see that we have a custom `PortsMailNotifier` class that inherits from `MailNotifier`, which is "same as original, but calls `portMessageFormatter` with access to interested_users". But I don't see where `portWatcherMessageFormatter` ever makes use of the `interested_users` argument its been passed.3 I've looked at [browser:contrib/buildbot-test/master.cfg the code] for a long time and don't understand it. Obviously the list of interested users isn't being cleared at the beginning of each build. But I don't see where in the code anything gets added to the list of interested users. I see that we have a custom `PortsMailNotifier` class that inherits from `MailNotifier`, which is "same as original, but calls `portMessageFormatter` with access to `interested_users`". But I don't see where `portWatcherMessageFormatter` ever makes use of the `interested_users` argument its been passed.