Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#54607 closed update (fixed)

cdo @1.8.2: update to 1.9.0

Reported by: l2dy (Zero King) Owned by: tenomoto (Takeshi Enomoto)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: aaschwanden (Andy Aschwanden), wk1984 (Kang)
Port: cdo

Description

https://code.mpimet.mpg.de/news/380

  • Code changed from ANSI C99 to ISO C++11

Attachments (2)

Portfile_openmp_1.9.1 (3.8 KB) - added by aaschwanden (Andy Aschwanden) 7 years ago.
Portfile-cdo.diff (1.7 KB) - added by aaschwanden (Andy Aschwanden) 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by Schamschula (Marius Schamschula)

Resolution: fixed
Status: newclosed

In 817df9ac92ebe0b7ea412dab580d141a14fbb6e5/macports-ports:

cdo: update to version 1.9.0

Closes: #54607

comment:2 in reply to:  1 Changed 7 years ago by pgf

Replying to Schamschula:

In 817df9ac92ebe0b7ea412dab580d141a14fbb6e5/macports-ports:

cdo: update to version 1.9.0

Closes: #54607


With this update we lose support for OpenMP in cdo, given that gcc is now blacklisted and clang does not support OpenMP AFAIK. Any idea on a possible workaround?

comment:3 Changed 7 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: closedreopened

Thanks for updating cdo to 1.9.0. However, the update port is broken. While pthread_mutex_lock() defined in src/pthread_debug.h is void, but a return value of type int is used in a few places, probably assuming pthread_mutex_lock() as defined in /usr/include/pthread.h. No changes have been made from 1.8.2 except for the change from C99 to C++11. cdo builds fine with configure-compiler=macports-gcc-6 although *gcc* is blacklisted due to PortGroup cxx11 1.0. Any ideas?

comment:4 Changed 7 years ago by aaschwanden (Andy Aschwanden)

Cc: aaschwanden added

comment:5 Changed 7 years ago by thiagoveloso (Thiago V. dos Santos)

I was just wondering if there is any update on this case?

I am also unable to install cdo due to several 'Pthread_mutex_lock(func, a)' errors.

This is my error log: https://pastebin.com/mN282EyQ

Last edited 7 years ago by thiagoveloso (Thiago V. dos Santos) (previous) (diff)

comment:6 Changed 7 years ago by wk1984 (Kang)

Cc: wk1984 added

comment:7 Changed 7 years ago by aaschwanden (Andy Aschwanden)

Updating to CDO 1.9.1 makes the pthread issue go away.

Regarding openmp support: Recent versions of clang support openmp (I don't know when full openmp support was introduced, I believe with clang 3.8). I've been able to compile CDO 1.9.1 with mpich-devel-clang50 / clang50 to get openmp working. If there is interest I can share my Portfile, however I'm not a Portfile expert so it would need a bit more testing.

Changed 7 years ago by aaschwanden (Andy Aschwanden)

Attachment: Portfile_openmp_1.9.1 added

comment:8 Changed 7 years ago by mf2k (Frank Schima)

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing.

Changed 7 years ago by aaschwanden (Andy Aschwanden)

Attachment: Portfile-cdo.diff added

comment:9 Changed 7 years ago by tenomoto (Takeshi Enomoto)

Resolution: fixed
Status: reopenedclosed

comment:10 Changed 7 years ago by tenomoto (Takeshi Enomoto)

Note: See TracTickets for help on using tickets.