Opened 7 years ago
Last modified 2 years ago
#54839 closed defect
Checksum mismatches for generated tarballs from GitHub — at Version 55
Reported by: | raimue (Rainer Müller) | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | aggraef@…, aronnax@…, ben@…, cjones051073 (Chris Jones), ctreleaven@…, dbevans (David B. Evans), devans@…, eborisch@…, fanfarillo.gcc@…, g5pw@…, galexv@…, gclawes, gjasny@…, glenn@…, graemelawes@…, howarth.at.macports@…, jheiss@…, jonesc@…, juanrgar@…, l2dy (Zero King), leonardo@…, lists@…, lpsinger (Leo Singer), me@…, milmazz (Milton Mazzarri), mk@…, mojca@…, neumann@…, pebrc (Peter Brachwitz), ryandesign (Ryan Carsten Schmidt), ryandesign@…, sean@…, sean@…, stromnov@…, takeshi@…, thibaut@…, vince@…, drkp (Dan Ports), SickTeddyBear, hansgans, michaellass (Michael Lass), vamsi765 | |
Port: | HermesApp LucenePlusPlus MongoHub apbs cusp lua-xavante mosesdecoder scm_breeze subsurface zorba |
Description (last modified by eborisch (Eric A. Borisch))
Apparently, GitHub upgraded their software and changed the way git tarballs are generated due to a bugfix in upstream git. The produced tarballs will differ from those that have been generated before.
The checksums of the following ports have changed due to this (ran against [ffdb5922289aca17f166d14e3e91ecbe52278c10/macports-ports]):
Port | Maintainer |
---|---|
ALPSCore | galexv@… |
apbs | howarth.at.macports@…,openmaintainer |
box2d | stromnov@…,openmaintainer |
certbot | mps@… Schamschula,openmaintainer |
cgminer | |
chapel | takeshi@…,openmaintainer |
cjdns | l2dy@… l2dy,openmaintainer |
coffee-script | ryandesign@…,openmaintainer |
cot | glenn@… |
csvToLedger | ben@… |
cusp | sean@…,openmaintainer |
DepreciateForLedger | ben@… |
docker | |
docker-machine | |
elixir | me@… milmazz |
expense.txt | ben@… |
faust-devel | ryandesign@…,aggraef@… |
faust2-devel | ryandesign@…,aggraef@… |
fbthrift | sean@…,openmaintainer |
fbthrift | sean@…,openmaintainer |
git-lfs | raimue@… raimue,openmaintainer |
gst-plugins-cairovis | aronnax@… lpsinger |
GTDtoCSV | ben@… |
Gyoto | thibaut@…,openmaintainer |
HermesApp | ryandesign@… ryandesign,openmaintainer |
htcondor | aronnax@… lpsinger |
hub | lists@… |
ifeffit | joe.fowler@…,openmaintainer |
Io | |
iTerm2 | emer@… |
jake | ryandesign@…,openmaintainer |
just | casey@… |
keybase | sean@…,openmaintainer |
keybinder | ryandesign@…,openmaintainer |
keybinder-3.0 | ryandesign@…,openmaintainer |
kops | pebrc,openmaintainer |
LedgerScheduler | ben@… |
libcdata | |
libcdatetime | |
libcerror | |
libcfile | |
libclocale | |
libcnotify | |
libcsplit | |
libcthreads | |
libewf | |
libgit2 | juanrgar@…,devans@… dbevans |
libiodbc | snc@…,openmaintainer |
libphonenumber-cpp | devans@… dbevans,openmaintainer |
litecoin | mk@…,openmaintainer |
lua-cgilua | |
lua-rings | |
lua-wsapi | |
lua-xavante | |
LucenePlusPlus | |
mame | |
meson | |
mogenerator | |
mongo-cxx-driver | ryandesign@…,openmaintainer |
mongo-tools | ryandesign@… ryandesign,openmaintainer |
MongoHub | ryandesign@…,openmaintainer |
mongrel2 | |
mosesdecoder | |
myrepos | gjasny@…,openmaintainer |
mythtv-core.25 | ctreleaven@…,openmaintainer |
mythtv-core.26 | ctreleaven@…,openmaintainer |
nu2 | |
ocaml-async-core | |
OpenCoarrays | fanfarillo.gcc@… |
pear-TCPDF | |
pficommon | |
phoenix | g5pw@…,openmaintainer |
phpsh | |
povray | |
QGIS | vince@… |
QLStephen | |
qoauth | |
racer | sean@…,openmaintainer |
rekall | |
root5 | jonesc@… cjones051073 |
scm_breeze | g5pw@…,openmaintainer |
ShiftIt | |
subsurface | |
syncthing-0.14 | leonardo@…,openmaintainer |
synergy | |
tDOM | neumann@… |
tbb | sean@… |
teleport | graemelawes@… gclawes,openmaintainer |
texworks | mojca@…,openmaintainer |
tidyp | |
time.txt | ben@… |
todotxt | snc@…,openmaintainer |
tpkg | jheiss@…,openmaintainer |
uzbl | ryandesign@… ryandesign,openmaintainer |
webkit-sharp | ryandesign@…,openmaintainer |
xctool | sean@…,openmaintainer |
xmlroff | |
zorba |
I do not know if GitHub actually invalidated the generated tarballs from their download caches, so the following might not be conclusive and checksums that are deemed correct might be subject to change in the future.
To track the progress, please do not edit above table as-is but remove fixed ports from the port
field in this ticket.
See also this similar report for Homebrew: https://github.com/Homebrew/homebrew-core/issues/18044
For reference, above list was generated with these commands:
$ grep -l -R '^github\.setup' . | xargs -I{} sh -c 'basename $(dirname {})' | while read port; do sudo port clean --all \; fetch --no-mirrors \ checksum || echo $port > github-failed.txt; done $ while read port; do port info --line --name --maintainer $port; done < <(sort -f github-failed.txt) | awk -F$'\t' '{printf "|| %-40s || %s ||\n", $2, $1}'
Change History (55)
comment:1 Changed 7 years ago by raimue (Rainer Müller)
comment:2 Changed 7 years ago by raimue (Rainer Müller)
comment:3 Changed 7 years ago by raimue (Rainer Müller)
Cc: | raimue raimue@… removed |
---|---|
Port: | git-lfs removed |
comment:4 follow-up: 5 Changed 7 years ago by nerdling (Jeremy Lavergne)
Cc: | snc@… removed |
---|---|
Port: | libiodbc todotxt removed |
I did get a changed distfile for todotxt (07842f8/macports-ports), but libiodbc seems to still be correct.
comment:5 Changed 7 years ago by raimue (Rainer Müller)
Replying to nerdling:
but libiodbc seems to still be correct.
You are right, I only checked if the command was successful and the problem with libiodbc was unrelated and temporary (502 Bad Gateway). I noticed now that the list also contains some other errors such as 404 Not Found for some ports. However, they need to be looked into anyway, so I am not re-running the whole thing.
comment:6 Changed 7 years ago by Schamschula (Marius Schamschula)
comment:7 Changed 7 years ago by Schamschula (Marius Schamschula)
Cc: | Schamschula mps@… removed |
---|
comment:8 Changed 7 years ago by lbschenkel (Leonardo Brondani Schenkel)
There's a new syncthing
release scheduled to happen in 3 days; since installing the pre-built binaries still works and this port has no variants that would force building from source, I think that the number of impacted users is on the low side and we can afford to wait so I can kill two birds with one stone. Sounds reasonable?
comment:9 Changed 7 years ago by raimue (Rainer Müller)
Users of a non-default prefix will not receive binary archives, although I agree there are probably not many. Fixing the checksums will not affect existing installations in any way. We can assume the content of the distfiles has not changed as they are still based on the same git commit. There is no need to increase the revision when fixing the checksums and it will not cause any rebuilds.
comment:10 Changed 7 years ago by mojca (Mojca Miklavec)
I planned to seize the opportunity to update texworks to 0.6.2 to avoid doing workarounds, but I cannot make it compile. I'll see if I can fix the problems quickly. If not, I'll do a workaround.
comment:11 Changed 7 years ago by l2dy (Zero King)
comment:12 Changed 7 years ago by l2dy (Zero King)
Cc: | l2dy@… removed |
---|---|
Port: | cjdns removed |
comment:13 Changed 7 years ago by Schamschula (Marius Schamschula)
comment:14 Changed 7 years ago by raimue (Rainer Müller)
Cc: | emer@… removed |
---|---|
Port: | iTerm2 removed |
comment:15 Changed 7 years ago by Schamschula (Marius Schamschula)
Port: | certbot removed |
---|
comment:16 Changed 7 years ago by casey (Casey Rodarmor)
Cc: | casey removed |
---|
comment:17 Changed 7 years ago by casey (Casey Rodarmor)
Cc: | casey added |
---|
comment:18 Changed 7 years ago by casey (Casey Rodarmor)
Cc: | casey removed |
---|
comment:19 Changed 7 years ago by lbschenkel (Leonardo Brondani Schenkel)
syncthing-0.14
has now been upgraded to a new upstream version, that also addresses the checksum problem
comment:20 Changed 7 years ago by l2dy (Zero King)
Port: | syncthing-0.14 removed |
---|
comment:21 Changed 7 years ago by joefowler (Joe Fowler)
See #54890: I tried to follow the instructions and update port ifeffit
. But as @ryandesign has politely pointed out, I did not actually have to change the checksums.
So can you check again that ifeffit
belongs on this list? If it does, then I guess I am totally confused about what to do.
comment:22 Changed 7 years ago by l2dy (Zero King)
Port: | ifeffit removed |
---|
comment:23 Changed 7 years ago by drkp (Dan Ports)
Cc: | drkp added |
---|
comment:24 Changed 7 years ago by raimue (Rainer Müller)
Cc: | joefowler removed |
---|
I can confirm ifeffit was a false positive, follow-up in #54890.
comment:25 Changed 7 years ago by Dan R. K. Ports <drkp@…>
comment:26 Changed 7 years ago by SickTeddyBear
Cc: | SickTeddyBear added |
---|
comment:27 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | hansgans added |
---|
Has duplicate #54910.
comment:28 Changed 7 years ago by cjones051073 (Chris Jones)
Description: | modified (diff) |
---|
tbb fixed (also updated to 2017_U8).
comment:29 Changed 7 years ago by cjones051073 (Chris Jones)
Description: | modified (diff) |
---|---|
Port: | tbb removed |
comment:30 Changed 7 years ago by michaellass (Michael Lass)
Cc: | michaellass added |
---|
comment:31 Changed 7 years ago by bokertov
Any update on when this will get fixed? This is preventing me from install packages such as Julia (see #55117). Thanks!
comment:32 Changed 7 years ago by raimue (Rainer Müller)
As soon as you provide updated checksums. It just needs someone to work through these ports and update the checksums.
comment:33 Changed 7 years ago by lbschenkel (Leonardo Brondani Schenkel)
Btw: syncthing-0.14
has been updated a while ago, I forgot to notify in this ticket.
comment:34 Changed 7 years ago by michaellass (Michael Lass)
At least for libgit2 I created a pull request some time ago which just needs to be merged: https://github.com/macports/macports-ports/pull/900
comment:35 Changed 7 years ago by Michael Lass <michael.lass@…>
comment:36 Changed 7 years ago by raimue (Rainer Müller)
Port: | libgit2 removed |
---|
comment:37 Changed 7 years ago by ctreleaven (Craig Treleaven)
comment:38 Changed 7 years ago by ctreleaven (Craig Treleaven)
mythtv-core.28 was not on the list but was affected by this issue. Now fixed.
Will sudo port distcheck blah
verify if a port suffers from this issue? Because I would expect mythweb.28 to be affected and it appears not to be.
comment:39 Changed 7 years ago by neverpanic (Clemens Lang)
comment:40 Changed 7 years ago by neverpanic (Clemens Lang)
Port: | keybase removed |
---|
comment:41 Changed 7 years ago by mojca (Mojca Miklavec)
comment:42 Changed 7 years ago by mojca (Mojca Miklavec)
Port: | texworks removed |
---|
comment:43 Changed 7 years ago by Alexander Gaenko <galexv@…>
comment:44 Changed 7 years ago by ctreleaven (Craig Treleaven)
comment:45 Changed 7 years ago by ctreleaven (Craig Treleaven)
Ports now obsolete and therefore checksums no longer relevant:
- mythtv-core.25: [14829fec8a6e4d888910197a0f47fff10b17032f/macports-ports]
- mythtv-core.26: [056d04d825a60266f409e0c94d89c48e627389c4/macports-ports]
- mythweb.25: [98b164f39ceeb9f7ebd2ff0866defde9fc74be5a/macports-ports]
- mythweb.26: [01c9b70862011ca711cda1bd3a298e29cd23a5d9/macports-ports]
comment:46 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | vamsi765 added |
---|
Has duplicate #55412 (docker).
comment:47 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
comment:48 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Port: | ALPSCore docker docker-machine libphonenumber-cpp mongo-tools mythtv-core.25 mythtv-core.26 qgis synergy removed |
---|
comment:49 Changed 7 years ago by vamsi765
Cc: | vamsi765 removed |
---|
comment:50 Changed 7 years ago by vamsi765
Cc: | vamsi765 added |
---|
comment:51 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
Port: | nu2 pficommon phpsh removed |
---|
comment:53 Changed 7 years ago by lpsinger (Leo Singer)
Port: | htcondor removed |
---|
I fixed htcondor in [f52105c01a0a2905b62d04d9fb98b3bb4e418553/macports-ports].
comment:54 Changed 7 years ago by Eric A. Borisch <eborisch@…>
comment:55 Changed 7 years ago by eborisch (Eric A. Borisch)
Description: | modified (diff) |
---|
In order to fix these ports, please apply the recipe from wiki:PortfileRecipes#stealth-updates by adding a
dist_subdir
.