#54894 closed enhancement (fixed)
Add Python 3.6 to py-pyaudio
| Reported by: | radarhere (Andrew Murray) | Owned by: | Jakker (Jaap Akkerhuis) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | petrrr | |
| Port: | py-pyaudio |
Description
If someone would be so kind as to add a py36 subport to py-pyaudio, that would be helpful.
Attachments (5)
Change History (22)
comment:1 Changed 7 years ago by mf2k (Frank Schima)
| Owner: | set to jaap@… |
|---|---|
| Status: | new → assigned |
| Type: | request → enhancement |
comment:3 Changed 7 years ago by petrrr
| Cc: | petrrr added |
|---|
comment:4 Changed 7 years ago by Jakker (Jaap Akkerhuis)
There is an update to pyaudio 0.2.11 coming soon. I'll add the Python 3.6 as well
Changed 7 years ago by Jakker (Jaap Akkerhuis)
| Attachment: | Portfile-py-pyaudio.diff added |
|---|
Patch to upgrade to version 0.2.11
comment:6 Changed 7 years ago by Jakker (Jaap Akkerhuis)
Attache Patch to upgrade. Apologies for the delay.
comment:7 follow-up: 8 Changed 7 years ago by mf2k (Frank Schima)
Is there a reason to add py26? I'd rather not add older versions of python, only newer.
comment:8 Changed 7 years ago by Jakker (Jaap Akkerhuis)
Replying to mf2k:
Is there a reason to add py26? I'd rather not add older versions of python, only newer.
Oops, forgot to take it out, sorry. Feel free to do so.
comment:9 Changed 7 years ago by mf2k (Frank Schima)
Your patch has a number of issues.
- You cannot depend on the stub port for py-sphinx and it must reside in the
if {${name} ne ${subport}} {block. - You are introducing tabs. Please use spaces.
- Use xinstall instead of mkdir and copy.
I am submitting my updated patch with fixes for all but the last. I apparently cannot figure out the correct syntax for xinstall even though I am following the guide.
Changed 7 years ago by mf2k (Frank Schima)
| Attachment: | Portfile-py-pyaudio.2.diff added |
|---|
comment:10 Changed 7 years ago by mf2k (Frank Schima)
@Jakker: I just noticed that your patch removes the build dependency on py-setuptools. Was that intended?
Changed 7 years ago by mf2k (Frank Schima)
| Attachment: | Portfile-py-pyaudio.3.diff added |
|---|
comment:11 follow-up: 13 Changed 7 years ago by mf2k (Frank Schima)
I have attached my latest version of the update but some issues remain:
- Why change the master_sites? The original works fine and does not require a unique code that will change for the next version.
- Why change the livecheck? It appears to work as is.
- Not using py-setuptools has raised red flags when I was discussing this on IRC.
- I still cannot get the xinstall commands to work correctly.
Changed 7 years ago by Jakker (Jaap Akkerhuis)
| Attachment: | Portfile-py-pyaudio.4.diff added |
|---|
newest version of upgrade patch
comment:12 follow-up: 14 Changed 7 years ago by mf2k (Frank Schima)
Thanks. Please attach the Portfile patch as a unified diff.
comment:13 Changed 7 years ago by Jakker (Jaap Akkerhuis)
Replying to mf2k:
I have attached my latest version of the update but some issues remain:
- Why change the master_sites? The original works fine and does not require a unique code that will change for the next version.
It didn't work for a while.
- Why change the livecheck? It appears to work as is.
Don't remembering touching it.
- Not using py-setuptools has raised red flags when I was discussing this on IRC.
It is back
- I still cannot get the xinstall commands to work correctly.
I was following the "file mkdir" example from the MacPort Guide but since you asked, I'm now using xinstall.
Changed 7 years ago by Jakker (Jaap Akkerhuis)
| Attachment: | Portfile-py-pyaudio.5.diff added |
|---|
Unified diff version
comment:14 Changed 7 years ago by Jakker (Jaap Akkerhuis)
comment:15 Changed 7 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:16 Changed 7 years ago by mf2k (Frank Schima)
Thanks! I kept the livecheck as is because it is simpler and appears to work correctly. I also tweaked the build dependencies to add them using a single statement rather than 2 statements.
In the future, please Cc the port maintainers (
port info --maintainers py-pyaudio).