#54986 closed defect (fixed)
swig-php: Add variants for php70, php71, make php71 the default
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | swig-php |
Description
swig-php currently defaults to php55. php55 has reached end of life. Please add variants for php70 and php71 and make php71 the default, since that's the latest stable version.
Change History (4)
comment:1 Changed 7 years ago by michaelld (Michael Dickens)
comment:2 Changed 7 years ago by michaelld (Michael Dickens)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)
I don't know how swig works or how users use swig; I don't know if there is benefit to building for a specific version of PHP. If there is, how about offering variants for all the version of PHP that the PHP port offers. 7.2 is the latest stable, so I would suggest that should be the default.
comment:4 Changed 7 years ago by michaelld (Michael Dickens)
Yeah I don't use this part of SWIG, so I don't know how it works. It looks from the contents of various variants that it installs the same files no matter which variant is selected; the actual PHP #include's don't even seem to be used. I've updated the port by adding the +php7X variants. I made 7.1 the default, but that's easy to change & I'll do so shortly. Thx for the feedback.
Revisiting this ticket. PHP72 is out ... should it be the default? should I keep php56 around too, just for legacy sake? deprecate 5[2-5]?