wireshark2 @2.4.2: can be broken if cmake is uninstalled after building

[yan12125 (Chih-Hsuan Yen)]

Steps to reproduce:

1. port -vt install wireshark2
2. port uninstall --follow-dependencies cmake

Now wireshark is broken:

$ /Applications/MacPorts/Wireshark.app/Contents/MacOS/Wireshark
dyld: Library not loaded: /opt/local/lib/liblz4.1.dylib
  Referenced from: /Applications/MacPorts/Wireshark.app/Contents/MacOS/Wireshark
  Reason: image not found
[1]    15194 abort      /Applications/MacPorts/Wireshark.app/Contents/MacOS/Wireshark

This is because cmake is installed and lz4 is brought in during the build time.

[mf2k (Frank Schima)]

cmake needs to be moved from being a build dependency to being a library dependency.

[Schamschula (Marius Schamschula)]

I wonder if this should be done in the cmake PortGroup, as this likely an issue with other ports.

[ghosthound]

I suspect this is because wireshark will use lz4 if it is available. lz4 is installed by libarchive which is installed by cmake, so for wireshark lz4 should be added as a dependency or configure args to disable lz4 should be added. I don't know if other ports will follow the same pattern, but it may not be a generic cmake issue.

[yan12125 (Chih-Hsuan Yen)]

As far as I understand it, this is a Wireshark-specific issue rather than a generic cmake one. Wireshark ​detects lz4 in its CMakeLists.txt, and it can be disabled with -DENABLE_LZ4=OFF.

lz4 is used in "Apache Cassandra CQL dissection" and "Kafka Protocol dissection". I'm not sure if those protocols are common or not. Considering that lz4 is a rather tiny package (112K tbz2 for Darwin 17), it won't hurt anyone to put it into depends_lib of wireshark2.

[ghosthound]

lz4 added as a dependency in [d3281bfda0047e9c311af5559265d73b969398d2/macports-ports]