Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#56110 closed defect (fixed)

Travis: skip building ports from the obsolete PortGroup

Reported by: mojca (Mojca Miklavec) Owned by: l2dy (Zero King)
Priority: Low Milestone:
Component: buildbot/mpbb Version:
Keywords: Cc: jmroot (Joshua Root), neverpanic (Clemens Lang), ryandesign (Ryan Carsten Schmidt)
Port:

Description

Our buildbot setup skips building ports from the obsolete PortGroup, while travis builds currently report a failure. Maybe we could skip building those ports on Travis as well if it's not too complicated. The code should already be in mpbb.

Change History (12)

comment:1 Changed 7 years ago by l2dy (Zero King)

mpbb checks for "already built" packages, which is not desired on Travis CI.

So we should re-implement the obsolete check in mpbot-github or implement a switch in mpbb to disable the "already built" check and use mpbb for listing subports.

Last edited 7 years ago by l2dy (Zero King) (previous) (diff)

comment:2 Changed 7 years ago by mojca (Mojca Miklavec)

Fix mpbb

comment:4 Changed 6 years ago by raimue (Rainer Müller)

In 868f68814515c2af4dc4c4921b489b7ded410e99/mpbb (master):

mpbb-list-subports: Allow empty --archive-site

Passing an empty string to --archive-site disables the checks on the
remote mirror.

See: #56110

comment:5 in reply to:  1 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

The request to have mpbot use mpbb-list-subports is #57563. However, I may not be understanding:

Replying to l2dy:

mpbb checks for "already built" packages, which is not desired on Travis CI.

By what means are we currently ensuring that prebuilt archives are not used on Travis? I don't see that happening. I remember within the past couple months we had a PR submitted which made a change to a port that made it unbuildable, but because the port's version and revision were not changed, Travis successfully downloaded the previously-built archive and reported a successful build, so the PR got merged. (I don't remember what port it was and can't find that PR again now.)

Or, is that what this PR is about? That we want Travis not to check for preexisting archives, but it's not currently programmed to do that? If so, then using mpbb-list-subports with empty --archive-site parameter should be the solution.

comment:6 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign added

comment:7 Changed 6 years ago by mojca (Mojca Miklavec)

I wanted to confirm that I observed the same issue: the port was theoretically built on Travis, but it just fetched the existing binary from our packages server and didn't actually do anything useful. I'm pretty sure this wasn't intended and I assume that @l2dy didn't want this to happen / wasn't aware this would happen. Do we have a ticket for that?

The request to have mpbot use mpbb-list-subports is #57563.

Indeed, if we switch to mpbb list-subports, both this ticket and #57563 would be addressed at the same time.

Both tickets report two different problems which both arise from the same decision / piece of code. Once that is fixed, both problems would be gone. (Nitpicking: no ticket has the title "Switch to mpbb", so you could equally well argue that this ticket is about switching to mpbb, just way older :) :) :)

Or, is that what this PR is about?

This ticket is precisely about what it says: it's annoying to get build failures for obsolete ports. (I don't care how it's solved, it could of course be done in go, but obviously switching to mpbb would address the issue in probably the most elegant way.)

That we want Travis not to check for preexisting archives, but it's not currently programmed to do that? If so, then using mpbb-list-subports with empty --archive-site parameter should be the solution.

  • We want Travis to actually build all (sub)ports modified in a PR, ideally in the same order as on the buildbot. Buildbot would skip building pre-existing archives, Travis should not.
  • We want Travis to fetch all dependencies (not modified in a PR) from a server (ideally one also providing non-distributable binaries, which is something you just work on, thanks a lot for that)

comment:8 Changed 6 years ago by l2dy (Zero King)

I'm aware of the issues, but currently I'm too busy to work on them. Hopefully I'll get more free time in a few weeks.

comment:9 in reply to:  7 Changed 6 years ago by l2dy (Zero King)

  • We want Travis to actually build all (sub)ports modified in a PR, ideally in the same order as on the buildbot. Buildbot would skip building pre-existing archives, Travis should not.

To be discussed in https://github.com/macports/macports-ports/pull/3353.

  • We want Travis to fetch all dependencies (not modified in a PR) from a server (ideally one also providing non-distributable binaries, which is something you just work on, thanks a lot for that)

We have a private package server now.

comment:10 in reply to:  description Changed 6 years ago by l2dy (Zero King)

Replying to mojca:

Our buildbot setup skips building ports from the obsolete PortGroup, while travis builds currently report a failure. Maybe we could skip building those ports on Travis as well if it's not too complicated. The code should already be in mpbb.

Fixed. See https://travis-ci.org/macports/macports-ports/builds/475921072 for an example.

comment:11 Changed 6 years ago by l2dy (Zero King)

Resolution: fixed
Status: newclosed

comment:12 Changed 6 years ago by mojca (Mojca Miklavec)

Thanks!

Note: See TracTickets for help on using tickets.