port reclaim fails with circular dependencies

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

Recently, port reclaim added the ability ​to removed unrequested port.
The procedure loops over every port and decides if it or one of its dependents is requested.
To facilitate this procedure, the ports are put in ​sorted order.
This works fine if ​the procedure sort_portlist_by_dependendents works as advertised.
If there is a circular dependency, then this is not possible.

Some circular dependencies are requested by the user.
For example:

• install librsvg
• install adwaita-icon-theme (depends on librsvg)
• install librsvg +viewer (depends on adwaita-icon-theme)

This results in Error: reclaim failed: can't read "isrequested(librsvg)": no such element in array if somehow these ports were unsetrequested.

This issue was recently discussed on the ​mailing list.