Opened 6 years ago

Closed 6 years ago

#57772 closed update (fixed)

reduce @20180920_0+doc: version update

Reported by: mbrethen Owned by: mbrethen
Priority: Normal Milestone:
Component: ports Version: 2.5.4
Keywords: Cc:
Port: reduce

Description (last modified by mf2k (Frank Schima))

Updates reduce to 20180920.

Closes these tickets: #56375, #55179

Attachments (12)

patch-csl-cslbase-create_bundle.sh.diff (754 bytes) - added by mbrethen 6 years ago.
patch-csl-cslbase-create_old_bundle.sh.diff (782 bytes) - added by mbrethen 6 years ago.
patch-generic-breduce-breduce.1.diff (460 bytes) - added by mbrethen 6 years ago.
patch-packages-plot-gnuintfc.red.diff (859 bytes) - added by mbrethen 6 years ago.
redcsl.1 (7.7 KB) - added by mbrethen 6 years ago.
redpsl.1 (192 bytes) - added by mbrethen 6 years ago.
runbootstrapreduce.sh (167 bytes) - added by mbrethen 6 years ago.
runcsl.sh (149 bytes) - added by mbrethen 6 years ago.
runcsllisp.sh (144 bytes) - added by mbrethen 6 years ago.
runpsl.sh (277 bytes) - added by mbrethen 6 years ago.
Portfile (8.8 KB) - added by mbrethen 6 years ago.
Portfile.diff (19.8 KB) - added by mbrethen 6 years ago.

Download all attachments as: .zip

Change History (21)

Changed 6 years ago by mbrethen

Changed 6 years ago by mbrethen

Changed 6 years ago by mbrethen

Changed 6 years ago by mbrethen

Changed 6 years ago by mbrethen

Attachment: redcsl.1 added

Changed 6 years ago by mbrethen

Attachment: redpsl.1 added

Changed 6 years ago by mbrethen

Attachment: runbootstrapreduce.sh added

Changed 6 years ago by mbrethen

Attachment: runcsl.sh added

Changed 6 years ago by mbrethen

Attachment: runcsllisp.sh added

Changed 6 years ago by mbrethen

Attachment: runpsl.sh added

comment:1 Changed 6 years ago by mbrethen

Description: modified (diff)

comment:2 Changed 6 years ago by mbrethen

Description: modified (diff)

comment:3 Changed 6 years ago by mf2k (Frank Schima)

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing.

comment:4 Changed 6 years ago by mf2k (Frank Schima)

Description: modified (diff)

Changed 6 years ago by mbrethen

Attachment: Portfile added

comment:5 Changed 6 years ago by mf2k (Frank Schima)

You have also incorporated whitespace changes which makes it much harder to determine what the actual changes are, and thus much less likely to get committed. Please either remove the whitespace changes or submit those in a separate diff.

comment:6 Changed 6 years ago by mbrethen

The Portfile was completely overhauled, I would expect that.

Last edited 6 years ago by mbrethen (previous) (diff)

Changed 6 years ago by mbrethen

Attachment: Portfile.diff added

comment:7 Changed 6 years ago by kencu (Ken)

I can try to work with you on this. It's a big package; looks interesting. I downloaded all the components and put them together into a PR. Just building it now (on Mojave).

Off the top, I can see it is setting a deployment target of some macOS versions ago, so we'll probably have to deal with that unless there's some good reason for it (there usually is not):

MACOSX_DEPLOYMENT_TARGET=10.10 /usr/bin/clang++ ...

with funky deployment settings you wind up with screenfuls of this:

ld: warning: object file (/opt/local/lib/libcurses.a(lib_napms.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libcurses.a(lib_ti.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libxcb.a(xcb_conn.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libxcb.a(xcb_out.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libfreetype.a(ftbitmap.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libfreetype.a(ftmm.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libfreetype.a(ftsystem.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libfreetype.a(ftbdf.o)) was built for newer OSX version (10.14) than being linked (10.10)
ld: warning: object file (/opt/local/lib/libfreetype.a(fttype1.o)) was built for newer OSX version (10.14) than being linked (10.10)

and who knows if there are any actual real errors in there or not? I can't tell you...

You're the maintainer so the Portfile can be however you want it to be, but there are certain conventions we usually use and I'll try to massage it into those once I have your version up and working. I'll put up a link to the PR and we can more easily work on it from there once it's up.

Trac is OK for working through build issues -- for that, I actually prefer it over the GitHub issues list, which is not so easy for me to use for issues (although some swear by it). But for this kind of thing -- a complicated port upgrade with lots of moving parts -- Trac is not so wonderful and I'm glad we moved away from it.

Keep you posted when I have the PR up. -- Ken

Last edited 6 years ago by kencu (Ken) (previous) (diff)

comment:8 Changed 6 years ago by kencu (Ken)

OK -- it's here <https://github.com/macports/macports-ports/pull/3209>. It builds, it runs! Let's see about any last little details.

comment:9 Changed 6 years ago by ken-cunningham-webuse

Resolution: fixed
Status: assignedclosed

In 699f0da0327a2cef477bbe03030e7b8ff4c9e6e5/macports-ports (master):

reduce: update to 20181123

also several changes:
rolled breduce subport into main port
added cxx11 1.1 PG which enables build on most systems
remove hardcoded deployment target in source
refactor Portfile

closes: #55179
closes: #56375
closes: #52998
closes: #57772
closes: #57592
closes: #57591

Note: See TracTickets for help on using tickets.