Changes between Initial Version and Version 2 of Ticket #57822


Ignore:
Timestamp:
Dec 28, 2018, 3:55:24 AM (6 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #57822

    • Property Status changed from new to assigned
    • Property Cc ewenmcneill added; mojca@… removed
    • Property Summary changed from cvs-fast-export: error on 10.14.2: 'CLOCK_REALTIME' macro redefined, and different types ('int' vs 'enum clockid_t') to cvs-fast-export: 'CLOCK_REALTIME' macro redefined, and different types ('int' vs 'enum clockid_t')
    • Property Keywords mojave added; cvs-fast-export CLOCK_REALTIME clockid_t removed
    • Property Owner set to mojca

  • Ticket #57822 – Description

    initial v2  
    22
    33{{{
    4 :info:build ./cvs.h:437:13: error: typedef redefinition with different types ('i
    5 nt' vs 'enum clockid_t')
     4:info:build ./cvs.h:437:13: error: typedef redefinition with different types ('int' vs 'enum clockid_t')
    65}}}
    76
    87{{{
    9 :info:build ./cvs.h:439:9: warning: 'CLOCK_REALTIME' macro redefined [-Wmacro-re
    10 defined]
     8:info:build ./cvs.h:439:9: warning: 'CLOCK_REALTIME' macro redefined [-Wmacro-redefined]
    119}}}
    1210
    13 This appears to be the same error as ticket:52388 (for macOS 10.12), [https://github.com/macports/macports-ports/commit/898ee2781b27a4e60f2f16366f46eb8b60316a47 fixed with a patch] about 18 months ago, on the [https://gitlab.com/esr/cvs-fast-export/issues/17 advice of upstream].
     11This appears to be the same error as ticket:52388 (for macOS 10.12), [changeset:898ee2781b27a4e60f2f16366f46eb8b60316a47/macports-ports fixed with a patch] about 18 months ago, on the [https://gitlab.com/esr/cvs-fast-export/issues/17 advice of upstream].
    1412
    15 However it appears this patch has been removed again (in two steps, [https://github.com/macports/macports-ports/commit/7d9000aaf4c3cb28a529aaec8c5baffba5ed60e9#diff-7d8182a960ad093810569ee6d01a938c commented out], then [https://github.com/macports/macports-ports/commit/587aa028e2c0f08b21a4bcb78d39821b989b271a#diff-7d8182a960ad093810569ee6d01a938c removed as unused]).  Which seems to leave the same build errors as before, since `cvs.h` now unconditionally redefines `CLOCK_REALTIME`, etc, on **all** Apple platforms again.  Possibly it was removed due to upstream including the patch upstream, but MacPorts hasn't updated to newer upstream?  Either way it does not build for me today.
     13However it appears this patch has been removed again (in two steps, [changeset:7d9000aaf4c3cb28a529aaec8c5baffba5ed60e9/macports-ports commented out], then [changeset:587aa028e2c0f08b21a4bcb78d39821b989b271a/macports-ports removed as unused]).  Which seems to leave the same build errors as before, since `cvs.h` now unconditionally redefines `CLOCK_REALTIME`, etc, on **all** Apple platforms again.  Possibly it was removed due to upstream including the patch upstream, but MacPorts hasn't updated to newer upstream?  Either way it does not build for me today.
    1614
    1715Perhaps the patch from ticket:52388 could be restored?  Or maybe there's a newer upstream version to package that includes this fix?