Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#58050 closed submission (fixed)

blueutil 2.4.0: new port

Reported by: DanielO (Daniel O'Connor) Owned by: ctreleaven (Craig Treleaven)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: blueutil

Description

A new port for blueutil and CLI tool to control pairing etc - https://github.com/toy/blueutil

Attachments (1)

blueutil-macport.tgz (1.0 KB) - added by DanielO (Daniel O'Connor) 6 years ago.

Download all attachments as: .zip

Change History (14)

Changed 6 years ago by DanielO (Daniel O'Connor)

Attachment: blueutil-macport.tgz added

comment:1 Changed 6 years ago by Schamschula (Marius Schamschula)

Keywords: haspatch added; has patch removed

comment:2 Changed 6 years ago by mf2k (Frank Schima)

Keywords: maintainer haspatch removed

comment:3 Changed 6 years ago by mf2k (Frank Schima)

The haspatch keyword is redundant for a submission port. In fact, there is no need for any keywords for a submission.

Last edited 6 years ago by mf2k (Frank Schima) (previous) (diff)

comment:4 Changed 6 years ago by ctreleaven (Craig Treleaven)

comment:5 Changed 6 years ago by ctreleaven (Craig Treleaven)

Resolution: fixed
Status: newclosed

Committed with a few changes. No need for name, version or homepage lines when using github.setup.

Re prefix, it is usually /opt/local but not always. Therefore we take a 2 step approach. In the second step, we use a reinplace to change the prefix to whatever the users ${PREFIX} is. Therefore in the first step, we set up a target "@PREFIX@" that the reinplace can look for.

Also notices that there were README.md and LICENSE.txt files that ought to be installed.

Finally, added support for the project's 'test' command.

Thanks for the submission and agreeing to act as maintainer. Feel free to contact me if you'd like to discuss.

comment:6 Changed 6 years ago by DanielO (Daniel O'Connor)

Ah yes, thanks.

I got an email saying it failed to build on the 'legacy builder'. https://build.macports.org/builders/ports-10.6_i386_legacy-builder/builds/60272/steps/install-port/logs/stdio

I'm not sure what the "right way" forward is - I would say just mark it as only working on a certain version of OSX but I don't know what the right value would be :)

comment:7 Changed 6 years ago by ctreleaven (Craig Treleaven)

Resolution: fixed
Status: closedreopened

I suspect it is using features introduced in a later version of the OS software. Could you contact the developer and ask what the minimum OS version is? We can add a test that aborts on unsupported systems.

BTW, I notice that the README mentions Homebrew. I believe HB only supports fairly recent versions of the OS. Thus they may not have run into this issue previously. You might make the developer aware that MacPorts is now also packaging the software.

Reopening this ticket while we sort this out.

comment:8 Changed 6 years ago by ctreleaven (Craig Treleaven)

Owner: set to ctreleaven
Status: reopenedassigned

comment:9 Changed 6 years ago by kencu (Ken)

The default compiler used on 10.6.8 is too old, but even if that were fixed, you have:

blueutil.m:234: error: cannot find protocol declaration for ‘IOBluetoothDeviceInquiryDelegate’

and that is 10.7+ SDK stuff <https://developer.apple.com/documentation/iobluetooth/iobluetoothdeviceinquirydelegate?language=objc>.

Edit: Looks like other parts are 10.9+.

Last edited 6 years ago by kencu (Ken) (previous) (diff)

comment:10 Changed 6 years ago by DanielO (Daniel O'Connor)

I checked with the maintainer and they made it explicitly 10.9+ recently - https://github.com/toy/blueutil/issues/16#issuecomment-466645989

It doesn't have a tag yet but I think that makes it definitive - how do I tell MacPorts about the version limit?

comment:11 Changed 6 years ago by kencu (Ken)

Something like this is traditional:

if { ${os.platform} eq "darwin" && ${os.major} <= 12} {
    pre-fetch {
        ui_error "${name} ${version} does not presently install on MacOSX 10.8 or earlier."
        return -code error "Unsupported platform"
    }
}

comment:12 in reply to:  10 Changed 6 years ago by ctreleaven (Craig Treleaven)

Resolution: fixed
Status: assignedclosed

Replying to DanielO:

I checked with the maintainer and they made it explicitly 10.9+ recently - https://github.com/toy/blueutil/issues/16#issuecomment-466645989

It doesn't have a tag yet but I think that makes it definitive - how do I tell MacPorts about the version limit?

Thanks for following up. I've commited @kencu 's version test:

https://github.com/macports/macports-ports/commit/6b06f05c1ee94ac1c25e2d2a52ce081ec38a0702

comment:13 Changed 6 years ago by DanielO (Daniel O'Connor)

Thanks!

Note: See TracTickets for help on using tickets.