Opened 5 years ago
Closed 5 years ago
#59098 closed defect (fixed)
pspg: error: Function clock_gettime not available
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | lbschenkel (Leonardo Brondani Schenkel) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | kencu (Ken) | |
| Port: | pspg |
Description
pspg fails to build on older systems (presumably on 10.11 and earlier) because:
checking for library containing clock_gettime... no configure: error: Function clock_gettime not available.
Using the legacy support port group may help.
Change History (8)
comment:1 Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)
comment:2 Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)
| Cc: | kencu added |
|---|
comment:3 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
I would say it's fine to just commit the change and monitor the buildbot waterfall to see whether that fixes the build. If it doesn't, the log that's generated may help you further. For example, some build systems need extra help to get the additional flags added by the legacy support port group into the build commands.
comment:4 Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)
comment:5 follow-up: 8 Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)
OK, there was a recent upstream release anyway so I took the opportunity and did both changes at once.
comment:6 Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)
Just curious: why isn't the logic present in this group enabled in base? Doesn't make it more sense to opt out of legacy support than opting in?
comment:7 Changed 5 years ago by kencu (Ken)
It's a thought -- but it breaks things unpredictably, like compiler building, so we thought - for now at least - to make it optional. Also, we were kinda worried about a few unexpected breakages on ports getting people on the wrong side of the fence on the whole idea.
Eventually, you are quite right, we should default it on and then opt out compilers and things that don't like it.
comment:8 Changed 5 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Replying to lbschenkel:
OK, there was a recent upstream release anyway so I took the opportunity and did both changes at once.
Thanks, looks like it worked. We have builds for 10.8 and up now, and the others just haven't been done yet because they're busy building other ports for the libc++ switchover.
Unfortunately I don't have such an old system, should I blindly add the
legacysupportgroup? Usually I avoid doing changes blind, I would prefer if somebody could confirm that it works.Maybe @kencu can chime in?