MacVim fails to build on macOS 10.15 Catalina

[moyang (Moyang Wang)]

The log file is attached.

[mf2k (Frank Schima)]

It looks like a patch error.

[mliker]

I believe the patch error only happens when there was already a previous unsuccessful build. The actual error is below. I don't get a patch error when I run port clean MacVim before running port upgrade MacVim

:info:patch --->  Running ibtool for Preferences.nib
:debug:patch system -W /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_MacVim/MacVim/work/macvim-155: ibtool --compile src/MacVim/English.lproj/Preferences.nib/keyedobjects.nib src/MacVim/English.lproj/Preferences.nib
:info:patch xcode-select: error: tool 'ibtool' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
:info:patch Command failed: ibtool --compile src/MacVim/English.lproj/Preferences.nib/keyedobjects.nib src/MacVim/English.lproj/Preferences.nib

[hexadecagram ({16/7})]

Replying to mliker:

I believe the patch error only happens when there was already a previous unsuccessful build. The actual error is below. I don't get a patch error when I run port clean MacVim before running port upgrade MacVim

I get the exact same error even with port clean MacVim or port clean --all MacVim. I have also tried sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer and it still produces the same error.

[rieder (Steven Rieder)]

Likewise, for me also port clean macvim before port install macvim doesn't help at all.

[nblievers]

The first issue is fixed by adding use_xcode yes to the Portfile. But then there is a compilation error, which seems kinda weird. It is easy enough to fix :

--- src/MacVim/PSMTabBarControl/source/PSMTabBarCell.h~	2019-10-25 15:01:08.000000000 +1100
+++ src/MacVim/PSMTabBarControl/source/PSMTabBarCell.h	2019-10-25 14:55:23.000000000 +1100
@@ -32,6 +32,7 @@
     BOOL                _hasIcon;
     int                 _count;
     NSString            *_toolTip;
+    PSMTabBarControl   *_controlView;
 }
 
 // creation/destruction

[libsystem-ethan]

Manually signing MacVim.app/Contents/MacOS/macvim-askpass, then rebuilding fixes the codesign error.

[vamsi765]

Is there any ETA on the fix to be delivered?

[dca58]

Same question as above, any news on this ?

[majoc-at-astro (majoc-at-astro)]

Replying to nblievers:

The first issue is fixed by adding use_xcode yes to the Portfile.

For completeness, I've found that necessary for our builds for 10.14 and 10.13 as well, though possibly for different reasons. Let me know if you'd like to see the logfiles, please.

[raimue (Rainer Müller)]

In e4b3d808a0739bb36c2060f8ccc52aa6b5cbbd6d/macports-ports (master):

MacVim: Add use_xcode option for MacPorts 2.6

See: #59235

[raimue (Rainer Müller)]

Sorry for not responding earlier, but I have no macOS 10.15 Catalina and therefore cannot help with debugging of this problem.

Please test again with MacVim @8.1.snapshot161, which was just pushed to master by me.

[sitrucz1 (Curtis Matz)]

It builds for me and works properly.

% sudo port sync && sudo port clean macvim && sudo port install macvim

--->  Updating the ports tree
--->  Cleaning MacVim
--->  Computing dependencies for MacVim
--->  Fetching archive for MacVim
--->  Attempting to fetch MacVim-8.1.snapshot161_0+huge.darwin_19.x86_64.tbz2 from https://packages.macports.org/MacVim
--->  Attempting to fetch MacVim-8.1.snapshot161_0+huge.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/MacVim
--->  Installing MacVim @8.1.snapshot161_0+huge
--->  Activating MacVim @8.1.snapshot161_0+huge
--->  Cleaning MacVim
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  No broken files found.                             
--->  No broken ports found.

[raimue (Rainer Müller)]

Thank you for the confirmation!

[raimue (Rainer Müller)]

In e4b3d808a0739bb36c2060f8ccc52aa6b5cbbd6d/macports-ports (dar, master, py38-reproject, revert-6945-rust-1.43.0, wireshark):

MacVim: Add use_xcode option for MacPorts 2.6

See: #59235