Changes between Version 2 and Version 3 of Ticket #59644, comment 5


Ignore:
Timestamp:
Dec 15, 2019, 4:44:42 AM (5 years ago)
Author:
Ionic (Mihai Moldovan)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #59644, comment 5

    v2 v3  
    11I'm carefully positive that we can close this ticket, since `mkvtoolnix` now formally depends upon Qt >= 5.9, which should fix the moc issue discussed here and sadly also means that the GUI won't be usable on older operating systems.
    22
    3 (Although, strictly speaking, if the moc bug is the only requirement for 5.9+, then we could revert the check back to the older value and fix up the build to not try to parse that file with moc - reenabling the GUI for older platforms. Processing a header with moc is only really needed for Qt objects and signals and slots, so in theory excluding that file should work.)
     3(Although, strictly speaking, if the moc bug is the only requirement for 5.9+, then we could revert the check back to the older value and fix up the build to not try to parse that file with moc - reenabling the GUI for older platforms. Processing a header with moc is only really needed for Qt objects and signals and slots, so in theory excluding that file should work.
     4
     5I looked into the repository and found out that the earlier version was compatible Qt 5.4+. They removed a bit of compatibility code with the newest release when bumping the requirement up to 5.9+, so it's not just fixing a moc issue.)