legacy-support: which replacement on Tiger not fully functional

[kencu (Ken)]

On Tiger, the which command has been modified slightly in legacy-support to make it match newer systems, to allow Makefiles and shell scripts to work as expected. It appears there is still some work to do on this.

This command, for example, functions correctly with a newer system which:

$ which autoconf-2.13 autoconf2.13 autoconf213
/opt/local/bin/autoconf213

but using our modified Tiger which, it doesn't function as expected:

/opt/macports-legacy-support/tiger_only/bin/which autoconf-2.13 autoconf2.13 autoconf213

-- returns nothing --

The which command on Tiger is a simple shell script, so hopefully won't be terribly hard to fix properly.

PS -- if you're interested, the which command in legacy-support is available here to try on any system <​https://github.com/macports/macports-legacy-support/blob/master/tiger_only/bin/which>

[kencu (Ken)]

This commit added the exit 1 and this is what broke it.

[484b4a33f8b9d34120f7b8697d81aa30a3cd4eaf/macports-legacy-support]

[kencu (Ken)]

Ping Thomas for thoughts. Presumably that exit 1 needs to be managed a bit differently.

[kencu (Ken)]

These both have to work -- System:

$ which autoconf-2.13 || which autoconf2.13 || which autoconf213
/opt/local/bin/autoconf213

$ which autoconf-2.13 autoconf2.13 autoconf213
/opt/local/bin/autoconf213

ours:

$ /opt/macports-legacy-support/tiger_only/bin/which autoconf-2.13 || /opt/macports-legacy-support/tiger_only/bin/which autoconf2.13 || /opt/macports-legacy-support/tiger_only/bin/which autoconf213
/opt/local/bin/autoconf213

$ /opt/macports-legacy-support/tiger_only/bin/which autoconf-2.13 autoconf2.13 autoconf213

[kencu (Ken)]

[3a9a65d54764eb0aefcb4af23f19907b408dffd7/macports-legacy-support]

[miniupnp (Thomas BERNARD)]

@kencu : sorry for my lack of responsiveness. You fix is perfect !